Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows same range for different source lines. #643

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

sashanicolas
Copy link
Contributor

Come to fix the other issue in #625

Now the multi_index_container does not have a unique key for ranges, which allows the same range to be added for multiple source lines.

@hainest
Copy link
Contributor

hainest commented Nov 4, 2019

@sashanicolas
Copy link
Contributor Author

How do you see exactly what are the tests that regressed?

@hainest
Copy link
Contributor

hainest commented Nov 5, 2019

@sashanicolas Clicking the number under the "Regressions" column will take you to the breakout of the regressions by host with the same architecture. You can then find the host you want on that page and click the "Direct Link" link to see a less cluttered version. That page needs cleaning up, but my CSS skills are garbage.

@hainest
Copy link
Contributor

hainest commented Nov 5, 2019

It looks like x86 needs the dev branch to work correctly. I will add this PR to that, and run it again.

@hainest
Copy link
Contributor

hainest commented Nov 13, 2019

I re-ran this on coriander just to check, and there are still lots of regressions relative to the head of master. I'm running on ARM now, as well.

@hainest
Copy link
Contributor

hainest commented Nov 13, 2019

No regressions on Zeroah.

@hainest
Copy link
Contributor

hainest commented Nov 14, 2019

No regressions on arm1.

@hainest
Copy link
Contributor

hainest commented Nov 17, 2019

https://bottle.cs.wisc.edu/branch/PR643

No regressions. The failure on coriander is non-deterministic, and is unrelated.

@hainest hainest merged commit 9fb741f into master Nov 17, 2019
@sashanicolas sashanicolas deleted the multiple_ranges_line_info branch March 30, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants