Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: photo viewer modal #305

Closed
chrismclarke opened this issue Jul 28, 2024 · 0 comments · Fixed by #307
Closed

feat: photo viewer modal #305

chrismclarke opened this issue Jul 28, 2024 · 0 comments · Fixed by #307
Assignees

Comments

@chrismclarke
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Following #292 there is now a photo-list component that displays a grid of all photos a user has taken. These photos are 120px x 120px to allow for reasonable list display, however are too small to see detail. It would be good if photos could be opened in a larger viewer on tap

Describe the solution you'd like
Add a dialog/modal template that can display the photo in larger format. This should automatically be opened on tap, and include a button to dismiss (and possibly also move the photo delete button to the modal).

Alternatives considered
There are existing packages (e.g. https://www.npmjs.com/package/viewerjs) to handle photo viewing, however these might be a bit overkill for our requirements

Additional context
It might be easiest to write the modal template within the same photo-view component. You can use mat dialog to launch a dialog using local html ng-template, see example in apps\picsa-apps\dashboard\src\app\modules\crop-information\pages\variety-details\variety-details.component.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants