Skip to content

Commit

Permalink
remove finished TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
heckstrahler committed Oct 18, 2023
1 parent 4ae8e04 commit 7d14d72
Showing 1 changed file with 0 additions and 25 deletions.
25 changes: 0 additions & 25 deletions pandapower/converter/cim/cim2pp/build_pp_net.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,55 +91,35 @@ def convert_to_pp(self, convert_line_to_switch: bool = False, line_r_limit: floa
pd.concat([self.cim['eq']['BaseVoltage'], self.cim['eq_bd']['BaseVoltage']],
sort=False, ignore_index=True)[['rdfId', 'nominalVoltage']]

# TODO:
# --------- convert busses ---------
self.classes_dict['connectivityNodesCim16'].ConnectivityNodesCim16(cimConverter=self).convert_connectivity_nodes_cim16()
# self._convert_connectivity_nodes_cim16()
# --------- convert external networks ---------
self.classes_dict['externalNetworkInjectionsCim16'].ExternalNetworkInjectionsCim16(cimConverter=self).convert_external_network_injections_cim16()
# self._convert_external_network_injections_cim16()
# --------- convert lines ---------
self.classes_dict['acLineSegmentsCim16'].AcLineSegmentsCim16(cimConverter=self).convert_ac_line_segments_cim16(convert_line_to_switch, line_r_limit, line_x_limit)
# self._convert_ac_line_segments_cim16(convert_line_to_switch, line_r_limit, line_x_limit)
self.classes_dict['dcLineSegmentsCim16'].DcLineSegmentsCim16(cimConverter=self).convert_dc_line_segments_cim16()
# self._convert_dc_line_segments_cim16()
# --------- convert switches ---------
self.classes_dict['switchesCim16'].SwitchesCim16(cimConverter=self).convert_switches_cim16()
# self._convert_switches_cim16()
# --------- convert loads ---------
self.classes_dict['energyConcumersCim16'].EnergyConsumersCim16(cimConverter=self).convert_energy_consumers_cim16()
# self._convert_energy_consumers_cim16()
self.classes_dict['conformLoadsCim16'].ConformLoadsCim16(cimConverter=self).convert_conform_loads_cim16()
# self._convert_conform_loads_cim16()
self.classes_dict['nonConformLoadsCim16'].NonConformLoadsCim16(cimConverter=self).convert_non_conform_loads_cim16()
# self._convert_non_conform_loads_cim16()
self.classes_dict['stationSuppliesCim16'].StationSuppliesCim16(cimConverter=self).convert_station_supplies_cim16()
# self._convert_station_supplies_cim16()
# --------- convert generators ---------
self.classes_dict['synchronousMachinesCim16'].SynchronousMachinesCim16(cimConverter=self).convert_synchronous_machines_cim16()
# self._convert_synchronous_machines_cim16()
self.classes_dict['asynchronousMachinesCim16'].AsynchronousMachinesCim16(cimConverter=self).convert_asynchronous_machines_cim16()
# self._convert_asynchronous_machines_cim16()
self.classes_dict['energySourcesCim16'].EnergySourceCim16(cimConverter=self).convert_energy_sources_cim16()
# self._convert_energy_sources_cim16()
# --------- convert shunt elements ---------
self.classes_dict['linearShuntCompensatorCim16'].LinearShuntCompensatorCim16(cimConverter=self).convert_linear_shunt_compensator_cim16()
# self._convert_linear_shunt_compensator_cim16()
self.classes_dict['nonLinearShuntCompensatorCim16'].NonLinearShuntCompensatorCim16(cimConverter=self).convert_nonlinear_shunt_compensator_cim16()
# self._convert_nonlinear_shunt_compensator_cim16()
self.classes_dict['staticVarCompensatorCim16'].StaticVarCompensatorCim16(cimConverter=self).convert_static_var_compensator_cim16()
# self._convert_static_var_compensator_cim16()
# --------- convert impedance elements ---------
self.classes_dict['equivalentBranchesCim16'].EquivalentBranchesCim16(cimConverter=self).convert_equivalent_branches_cim16()
# self._convert_equivalent_branches_cim16()
self.classes_dict['seriesCompensatorsCim16'].SeriesCompensatorsCim16(cimConverter=self).convert_series_compensators_cim16()
# self._convert_series_compensators_cim16()
# --------- convert extended ward and ward elements ---------
self.classes_dict['equivalentInjectionsCim16'].EquivalentInjectionsCim16(cimConverter=self).convert_equivalent_injections_cim16()
# self._convert_equivalent_injections_cim16()
# --------- convert transformers ---------
self.classes_dict['powerTransformersCim16'].PowerTransformersCim16(cimConverter=self).convert_power_transformers_cim16()
# self._convert_power_transformers_cim16()

# create the geo coordinates
gl_or_dl = str(self.kwargs.get('use_GL_or_DL_profile', 'both')).lower()
Expand All @@ -155,9 +135,7 @@ def convert_to_pp(self, convert_line_to_switch: bool = False, line_r_limit: floa
if self.cim['gl']['Location'].index.size > 0 and self.cim['gl']['PositionPoint'].index.size > 0 and \
use_gl_profile:
try:
# TODO:
self.classes_dict['geoCoordinatesFromGLCim16'].GeoCoordinatesFromGLCim16(cimConverter=self).add_geo_coordinates_from_gl_cim16()
# self._add_geo_coordinates_from_gl_cim16()
except Exception as e:
self.logger.warning("Creating the geo coordinates failed, returning the net without geo coordinates!")
self.logger.exception(e)
Expand All @@ -173,9 +151,7 @@ def convert_to_pp(self, convert_line_to_switch: bool = False, line_r_limit: floa
self.cim['dl']['DiagramObjectPoint'].index.size > 0 and self.net.bus_geodata.index.size == 0 and \
use_dl_profile:
try:
# TODO:
self.classes_dict['coordinatesFromDLCim16'].CoordinatesFromDLCim16(cimConverter=self).add_coordinates_from_dl_cim16(diagram_name=kwargs.get('diagram_name', None))
# self._add_coordinates_from_dl_cim16(diagram_name=kwargs.get('diagram_name', None))
except Exception as e:
self.logger.warning("Creating the coordinates failed, returning the net without coordinates!")
self.logger.exception(e)
Expand All @@ -189,7 +165,6 @@ def convert_to_pp(self, convert_line_to_switch: bool = False, line_r_limit: floa
self.net = pp_tools.set_pp_col_types(net=self.net)

# create transformer tap controller
# TODO:
self.classes_dict['tapController'].TapController(cimConverter=self).create_tap_controller_for_power_transformers()

self.logger.info("Running a power flow.")
Expand Down

0 comments on commit 7d14d72

Please sign in to comment.