Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The array index will not be correctly found when pvpq array is not sorted #1

Closed
chengts95 opened this issue Feb 4, 2017 · 3 comments

Comments

@chengts95
Copy link
Contributor

Check This line
pvpq_lookup = zeros(pvpq[-1]+1, dtype=int), I think the pvpq[-1] may not always be the largest index of the pvpq array, it should be like pvpq_lookup = zeros(pvpq).max() , dtype=int) to ensure the largest index will be always found. This can help to compatible with common pypower case format.

@lthurner
Copy link
Collaborator

lthurner commented Feb 6, 2017

The functions in pandapower/pypower_extension are for now only recommended to use within pandapower, not with casefiles that were not generated by pandapower.

We want to make the numba accelerations available for pypower, so that they work for all pypower casefiles. There are probably some issues to resolve before this generally works, and this is one of them, so thanks for pointing it out. For now, this is nothing that needs fixing in pandapower, since it works for casefiles generated by pandpower (pandapower always creates casefiles with consequitie bus numbering).

@chengts95
Copy link
Contributor Author

Thanks for the reply, I was calculating a customized power systemwhich had been created in pypower before in pandapower. In fact I used the converter.fromppc at first, but the conversion was a little inaccurate due to the differences in the transformer's model(seems to be another issue). that is why I modified some functions in pypower_extension to make the pandapower's runpf directly compatible with pypower cases to verify the results.

@jhmenke
Copy link
Contributor

jhmenke commented Feb 7, 2017

If the transformer caused differences after conversion, you can take a look at the trafo_model parameter of your transformers. Maybe changing the type from "t" to "pi" or vice versa is enough to fix your problem.

http://www.uni-kassel.de/eecs/fileadmin/datas/fb16/Fachgebiete/energiemanagement/Software/pandapower-doc/elements/trafo.html#electric-model

@lthurner lthurner closed this as completed May 2, 2017
lthurner pushed a commit that referenced this issue May 8, 2017
lthurner pushed a commit that referenced this issue Oct 11, 2017
lthurner pushed a commit that referenced this issue Oct 11, 2017
…n max_loading_percent)

-> correct line.max_i_ka in power_system_test_cases
close #1
lthurner pushed a commit that referenced this issue Oct 11, 2017
lthurner pushed a commit that referenced this issue Oct 11, 2017
…n max_loading_percent)

-> correct line.max_i_ka in power_system_test_cases
close #1
lthurner pushed a commit that referenced this issue Apr 24, 2018
FlorianShepherd pushed a commit that referenced this issue Aug 2, 2019
Update all develop commits
FlorianShepherd pushed a commit that referenced this issue Dec 19, 2019
lthurner pushed a commit that referenced this issue Mar 12, 2020
Test update from original pp
wangzhenassd added a commit that referenced this issue Jan 14, 2021
Initial commit of IEC 60909-4 section 6 test case.
rbolgaryn added a commit that referenced this issue May 31, 2021
rbolgaryn pushed a commit that referenced this issue Nov 2, 2022
ZhengLiu1119 added a commit that referenced this issue Jan 26, 2023
rbolgaryn pushed a commit that referenced this issue Jun 6, 2023
…on-suggestions

Feature/pgm integration suggestions
SteffenMeinecke pushed a commit that referenced this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants