Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving piggyback heartbeat sending. [1.9.x] #887

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

richiware
Copy link
Member

Avoid sending several piggyback heartbeat in a RTPS message with several DATA. This behavior occurs when StatefulWriter::send_any_unsent_changes() packs several DATA.

@richiware richiware changed the title Improving piggyback heartbeat sending. Improving piggyback heartbeat sending. [1.9.x] Nov 26, 2019
@richiware
Copy link
Member Author

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status
  • Performance Build Status

@richiware richiware mentioned this pull request Nov 28, 2019
8 tasks
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MiguelCompany MiguelCompany added this to the v1.9.4 milestone Nov 28, 2019
@MiguelCompany MiguelCompany merged commit 1bd1ea4 into 1.9.x Dec 11, 2019
@MiguelCompany MiguelCompany deleted the feature/improve-piggyback-heartbeat/1.9.x branch December 11, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants