Add codesigning settings

.travis.yml

@@ -1,4 +1,4 @@
 language: objective-c
-osx_image: xcode9
+osx_image: xcode11.2
 script:
-  - set -o pipefail && xcodebuild -project ProvisionQL.xcodeproj -scheme ProvisionQL | xcpretty
+  - set -o pipefail && xcodebuild -project ProvisionQL.xcodeproj -scheme ProvisionQL CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO | xcpretty

CHANGELOG.md

@@ -1,5 +1,9 @@
 # ProvisionQL
 
+## Version 1.6.1
+
+* Adds code signing, fixes macOS Catalina compatibility ([#30](https://github.com/ealeksandrov/ProvisionQL/issues/30))
+
 ## Version 1.6.0
 
 * Adds dark mode support ([#29](https://github.com/ealeksandrov/ProvisionQL/pull/29))

LICENSE.md

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2013-2018 Evgeny Aleksandrov
+Copyright (c) 2013-2019 Evgeny Aleksandrov
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

ProvisionQL.xcodeproj/project.pbxproj

@@ -50,6 +50,7 @@
 		55DB728E186E193500CAFEE7 /* GenerateThumbnailForURL.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = GenerateThumbnailForURL.m; sourceTree = "<group>"; };
 		55DB7290186E193500CAFEE7 /* GeneratePreviewForURL.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = GeneratePreviewForURL.m; sourceTree = "<group>"; };
 		55DB729A186E195500CAFEE7 /* Security.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Security.framework; path = System/Library/Frameworks/Security.framework; sourceTree = SDKROOT; };
+		AE61B2AE236C969C003749A1 /* autoupdate-revision.sh */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.sh; path = "autoupdate-revision.sh"; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
 /* Begin PBXFrameworksBuildPhase section */
@@ -111,6 +112,7 @@
 		555E951A186E2DC0001D406A /* Scripts */ = {
 			isa = PBXGroup;
 			children = (
+				AE61B2AE236C969C003749A1 /* autoupdate-revision.sh */,
 				555E951B186E2DC0001D406A /* install.sh */,
 			);
 			path = Scripts;
@@ -206,14 +208,20 @@
 			attributes = {
 				LastUpgradeCheck = 1000;
 				ORGANIZATIONNAME = "Evgeny Aleksandrov";
+				TargetAttributes = {
+					55DB727C186E193500CAFEE7 = {
+						DevelopmentTeam = 5567X9EQ9Q;
+						ProvisioningStyle = Manual;
+					};
+				};
 			};
 			buildConfigurationList = 55DB7276186E193500CAFEE7 /* Build configuration list for PBXProject "ProvisionQL" */;
 			compatibilityVersion = "Xcode 3.2";
-			developmentRegion = English;
+			developmentRegion = en;
 			hasScannedForEncodings = 0;
 			knownRegions = (
-				English,
 				en,
+				Base,
 			);
 			mainGroup = 55DB7272186E193500CAFEE7;
 			productRefGroup = 55DB727E186E193500CAFEE7 /* Products */;
@@ -260,7 +268,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "sh ProvisionQL/Scripts/install.sh\n";
+			shellScript = "sh ProvisionQL/Scripts/autoupdate-revision.sh\nsh ProvisionQL/Scripts/install.sh\n";
 		};
 /* End PBXShellScriptBuildPhase section */
 
@@ -378,9 +386,17 @@
 		55DB7298186E193500CAFEE7 /* Debug */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
+				CODE_SIGN_IDENTITY = "Developer ID Application";
+				CODE_SIGN_INJECT_BASE_ENTITLEMENTS = NO;
+				CODE_SIGN_STYLE = Manual;
 				COMBINE_HIDPI_IMAGES = YES;
+				CURRENT_PROJECT_VERSION = 1;
+				DEVELOPMENT_TEAM = 5567X9EQ9Q;
+				ENABLE_HARDENED_RUNTIME = YES;
 				INFOPLIST_FILE = "ProvisionQL/Supporting-files/Info.plist";
 				INSTALL_PATH = /Library/QuickLook;
+				MARKETING_VERSION = 1.6.1;
+				OTHER_CODE_SIGN_FLAGS = "--timestamp";
 				PRODUCT_BUNDLE_IDENTIFIER = com.ealeksandrov.ProvisionQL;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WRAPPER_EXTENSION = qlgenerator;
@@ -390,9 +406,17 @@
 		55DB7299186E193500CAFEE7 /* Release */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
+				CODE_SIGN_IDENTITY = "Developer ID Application";
+				CODE_SIGN_INJECT_BASE_ENTITLEMENTS = NO;
+				CODE_SIGN_STYLE = Manual;
 				COMBINE_HIDPI_IMAGES = YES;
+				CURRENT_PROJECT_VERSION = 1;
+				DEVELOPMENT_TEAM = 5567X9EQ9Q;
+				ENABLE_HARDENED_RUNTIME = YES;
 				INFOPLIST_FILE = "ProvisionQL/Supporting-files/Info.plist";
 				INSTALL_PATH = /Library/QuickLook;
+				MARKETING_VERSION = 1.6.1;
+				OTHER_CODE_SIGN_FLAGS = "--timestamp";
 				PRODUCT_BUNDLE_IDENTIFIER = com.ealeksandrov.ProvisionQL;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WRAPPER_EXTENSION = qlgenerator;

ProvisionQL/GeneratePreviewForURL.m

@@ -630,6 +630,9 @@ OSStatus GeneratePreviewForURL(void *thisInterface, QLPreviewRequestRef preview,
         [synthesizedInfo setObject:@"" forKey:@"DEBUG"];
 #endif
 
+        synthesizedValue = [[NSBundle bundleWithIdentifier:kPluginBundleId] objectForInfoDictionaryKey:@"CFBundleShortVersionString"];
+        [synthesizedInfo setObject:synthesizedValue forKey:@"BundleShortVersionString"];
+
         synthesizedValue = [[NSBundle bundleWithIdentifier:kPluginBundleId] objectForInfoDictionaryKey:@"CFBundleVersion"];
         [synthesizedInfo setObject:synthesizedValue forKey:@"BundleVersion"];
 

ProvisionQL/Resources/template.html

@@ -184,7 +184,7 @@ <h2>File info</h2>
             __FileInfo__<br />
         </div>
         <div class="footer">
-            <p>ProvisionQL v__BundleVersion____DEBUG__ (<a href="https://github.com/ealeksandrov/ProvisionQL">Fork on GitHub</a>)</p>
+            <p>ProvisionQL v__BundleShortVersionString__ (__BundleVersion__) __DEBUG__ (<a href="https://github.com/ealeksandrov/ProvisionQL">Fork on GitHub</a>)</p>
         </div>
     </body>
 </html>

ProvisionQL/Scripts/autoupdate-revision.sh

@@ -0,0 +1,12 @@
+#!/bin/sh
+# autoupdate-revision.sh
+
+git=`sh /etc/profile; which git`
+branch=`${git} rev-parse --abbrev-ref HEAD`
+commits_count=`${git} rev-list ${branch} | wc -l  | tr -d ' '`
+
+filepath="${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH}"
+
+echo "Updating ${filepath}"
+echo "Current version build ${commits_count}"
+/usr/libexec/PlistBuddy -c "Set :CFBundleVersion ${commits_count}" "${filepath}"

ProvisionQL/Supporting-files/Info.plist

@@ -29,9 +29,9 @@
 	<key>CFBundleName</key>
 	<string>${PRODUCT_NAME}</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1</string>
+	<string>$(MARKETING_VERSION)</string>
 	<key>CFBundleVersion</key>
-	<string>1.6.0</string>
+	<string>$(CURRENT_PROJECT_VERSION)</string>
 	<key>CFPlugInDynamicRegisterFunction</key>
 	<string></string>
 	<key>CFPlugInDynamicRegistration</key>