Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax span requirement for tracing-distributed #16

Open
Infrasonics opened this issue Jan 31, 2022 · 0 comments
Open

Relax span requirement for tracing-distributed #16

Infrasonics opened this issue Jan 31, 2022 · 0 comments

Comments

@Infrasonics
Copy link
Contributor

Currently tracing-distributed only sends traces that have an explicit parent span. This is hardcoded, the comments are rather clear and it silently ignores when an out of span event is attempted to be recorded (which was hard to find) .

None => {} // not part of a trace, don't bother recording via honeycomb

Yet my opinion is that this is a leftover from when the projects were one. I think the place to decide whether something is worth logging or not is a per-layer filter and should be exposed to the user that way.
Dragging a span around just for the sake of making the layer work is a cumbersome workaround.

Do you think this requirement could be relaxed? Maybe this would require some kind of pseudo parent-id when it's in the root span. Overall this change in behavior would make the whole crate more flexible. If you're not opposed in general, I'll try to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant