You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently tracing-distributed only sends traces that have an explicit parent span. This is hardcoded, the comments are rather clear and it silently ignores when an out of span event is attempted to be recorded (which was hard to find) .
None => {}// not part of a trace, don't bother recording via honeycomb
Yet my opinion is that this is a leftover from when the projects were one. I think the place to decide whether something is worth logging or not is a per-layer filter and should be exposed to the user that way.
Dragging a span around just for the sake of making the layer work is a cumbersome workaround.
Do you think this requirement could be relaxed? Maybe this would require some kind of pseudo parent-id when it's in the root span. Overall this change in behavior would make the whole crate more flexible. If you're not opposed in general, I'll try to help.
The text was updated successfully, but these errors were encountered:
Currently tracing-distributed only sends traces that have an explicit parent span. This is hardcoded, the comments are rather clear and it silently ignores when an out of span event is attempted to be recorded (which was hard to find) .
tracing-honeycomb/tracing-distributed/src/telemetry_layer.rs
Line 214 in 5a41b13
Yet my opinion is that this is a leftover from when the projects were one. I think the place to decide whether something is worth logging or not is a per-layer filter and should be exposed to the user that way.
Dragging a span around just for the sake of making the layer work is a cumbersome workaround.
Do you think this requirement could be relaxed? Maybe this would require some kind of pseudo parent-id when it's in the root span. Overall this change in behavior would make the whole crate more flexible. If you're not opposed in general, I'll try to help.
The text was updated successfully, but these errors were encountered: