windows icon not working

[ebrahimebrahim]

https://godot-es-docs.readthedocs.io/en/latest/getting_started/workflow/export/changing_application_icon_for_windows.html

[yusufmte]

The windows icon requires the use of a tool that needs windows or wine (https://github.com/electron/rcedit/releases).

The following was the result of using rcedit to export the game from Godot with windows (the icon worked, but the game wouldn't launch):

This is the result of a known error (godotengine/godot#33466) that occurs when (1) the rcedit tool is used and (2) the pck is embedded.

So I tried to use rcedit without embedding the pck and it worked:

It peuped out the .exe and then a .pck, which I'm assuming needs to be in the same directory as the .exe for it to work.

We have three options moving forward:
(1) Try to look harder for a way to make the icon correct while also embedding the .pck
(2) Accept the unembedded .pck, and just offer a .zip containing the .exe+.pck on download for the Windows version
(3) Accept the incorrect icon, and embed the .pck

What do you think?

[ebrahimebrahim]

Not embedding the pck sounds okay

[yusufmte]

Closing this issue. We just need to remember these steps for exporting the windows executable.