Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to secure and maintained hashing in UserDataPersister for the activation key #2382

Open
BacLuc opened this issue Jan 10, 2022 · 2 comments

Comments

@BacLuc
Copy link
Contributor

BacLuc commented Jan 10, 2022

Ist md5 wirklich noch ein sinnvoller Hash-Algorithmus für so etwas? Wie wärs wenn wir etwas wie https://github.com/symfony/password-hasher brauchen was auch rückwärtskompatibel auf dem aktuellen Stand der Technik gehalten wird?

Originally posted by @carlobeltrame in #2377 (comment)

And when we are at it, we can use the same mechanism with the then secure hash to only store hashes for the invitekey of campcollaborations.

@BacLuc
Copy link
Contributor Author

BacLuc commented Feb 14, 2023

Still needed for the activation key, but implemented for inviteKey.

@BacLuc BacLuc moved this to Validate if Done in Development Kanban Aug 27, 2023
@BacLuc BacLuc moved this from Validate if Done to Ready for implementation in Development Kanban Apr 27, 2024
@BacLuc
Copy link
Contributor Author

BacLuc commented Apr 27, 2024

if ($data->activationKeyHash === md5($data->activationKey)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for implementation
Development

No branches or pull requests

1 participant