Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimization big plan #3717

Closed
BacLuc opened this issue Aug 15, 2023 · 4 comments
Closed

Performance optimization big plan #3717

BacLuc opened this issue Aug 15, 2023 · 4 comments
Labels

Comments

@BacLuc
Copy link
Contributor

BacLuc commented Aug 15, 2023

Overall Plan

  1. Start with a dedicated Print endpoint that we don't have to improve the performance off all other endpoints PrintDataController Entpoint draft #3612
  2. Maybe optimize the endpoints we still need to optimize (with tests that the same properties are returned) (Performance optimization #3539, api: add snapshot tests of the responses #3622, UnitTest testSqlQueryCount for GetEntity and GetCollection #3602 , Activity fetch behaviour #3555 )
  3. In the meantime start with the cache with e.g. ContentType, then Category in Camp (Goal, cache is running for most endpoints in ca 2 years) POC: HTTP reverse proxy cache #3610
@BacLuc BacLuc added the Epic label Aug 15, 2023
@BacLuc BacLuc changed the title Performance Optimierung Performance optimization big plan Aug 15, 2023
@BacLuc
Copy link
Contributor Author

BacLuc commented Oct 10, 2023

For point 2:
I tested the new uriTemplate feature of api-platform 3.2, and it has a big potential.
BacLuc#208
@usu Did i use the feature correctly?

I propose we suspend our optimization effort without that feature, and use the uriTemplate feature as soon as we upgraded to api-platform 3.2

@carlobeltrame
Copy link
Member

We are now on api platform 3.2. So we can continue with trying to use the native api platform uriTemplate feature now, correct?

@BacLuc
Copy link
Contributor Author

BacLuc commented Nov 18, 2023

We are now on api platform 3.2. So we can continue with trying to use the native api platform uriTemplate feature now, correct?

@usu proposed that we do that together with the migration to sub resources that we only need to touch the endpoints once.
But for that we need api-platform/core#5758 that the sub resources can also help with the caching.
So I paused my efforts for now.

@BacLuc
Copy link
Contributor Author

BacLuc commented Apr 27, 2024

i close this as all proposed steps either failed or are ready as WIP PR, and can be merged as soon as api-platform is ready

@BacLuc BacLuc closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants