-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for highlight groups of listed plugins #1167
Comments
Thanks for the suggestion! Those are fairly new plugins, so I'd rather wait until highlight group names are fairly stable. In the meantime, what highlights do you miss when applied 'mini.hues' or 'mini.base16'? |
What you said makes sense but if possible and if it might not be a huge task can you please consider supporting render-markdown.nvim. helpview.nvim makes sense since it is newer. |
Hi! I also added fzf-lua and trouble.nvim. Trouble.nvim v4 had a big rewrite recently and a lot of new highlight groups have been added. |
What exactly you think is missing from 'folke/trouble.nvim' (which is already supported) and 'ibhagwan/fzf-lua' (which looks fine the last time I checked)? |
I believe this plugin render-markdown is well-established, given that it's been in development for over three months and has made its way into the default plugins of the LazyVim distro. I use it daily with base16 module. |
Thanks for the insight! I am afraid, both of these observations are not enough for me. Besides, "made its way into the default plugins of the LazyVim distro" is at least not accurate, as it is part of "Extra" for markdown language and is not "default" (which are arguably the ones included by default, i.e. 'mini.ai', 'mini.pairs', 'folke/lazy.nvim', 'folke/which-key.nvim', etc.). |
No worries at all.
That’s correct, it’s the default within the markdown language bundle under "Extra." I apply those highlights every time I change themes, so it works just fine for me. Cheers! |
Contributing guidelines
Module(s)
mini.hues, mini.base16
Description
Hii echasnovski! Can the following plugin highlights be supported by mini.hues and mini.base16 if possible.
https://github.com/OXY2DEV/helpview.nvim
https://github.com/MeanderingProgrammer/render-markdown.nvim
https://github.com/OXY2DEV/markview.nvim
https://github.com/ibhagwan/fzf-lua
https://github.com/folke/trouble.nvim - new v4 rewrite adds new highlights
The text was updated successfully, but these errors were encountered: