Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for highlight groups of listed plugins #1167

Open
2 tasks done
231tr0n opened this issue Aug 21, 2024 · 9 comments
Open
2 tasks done

Add support for highlight groups of listed plugins #1167

231tr0n opened this issue Aug 21, 2024 · 9 comments

Comments

@231tr0n
Copy link

231tr0n commented Aug 21, 2024

Contributing guidelines

Module(s)

mini.hues, mini.base16

Description

Hii echasnovski! Can the following plugin highlights be supported by mini.hues and mini.base16 if possible.
https://github.com/OXY2DEV/helpview.nvim
https://github.com/MeanderingProgrammer/render-markdown.nvim
https://github.com/OXY2DEV/markview.nvim
https://github.com/ibhagwan/fzf-lua
https://github.com/folke/trouble.nvim - new v4 rewrite adds new highlights

@echasnovski
Copy link
Owner

Thanks for the suggestion!

Those are fairly new plugins, so I'd rather wait until highlight group names are fairly stable.

In the meantime, what highlights do you miss when applied 'mini.hues' or 'mini.base16'?

@231tr0n
Copy link
Author

231tr0n commented Aug 21, 2024

I use onedark base16 color palette and the output for render-markdown.nvim looks something of this sort:-
image
The output for helpview.nvim looks like this
image
I mean the colors dont blend well in the case of helpview.nvim and they blend way too much in the case of render-markdown.nvim

@231tr0n
Copy link
Author

231tr0n commented Aug 21, 2024

Thanks for the suggestion!

Those are fairly new plugins, so I'd rather wait until highlight group names are fairly stable.

In the meantime, what highlights do you miss when applied 'mini.hues' or 'mini.base16'?

What you said makes sense but if possible and if it might not be a huge task can you please consider supporting render-markdown.nvim. helpview.nvim makes sense since it is newer.

@231tr0n 231tr0n changed the title Support for MeanderingProgrammer/render-markdown.nvim, OXY2DEV/helpview.nvim and OXY2DEV/markview.nvim Support for the listed plugins Aug 21, 2024
@231tr0n
Copy link
Author

231tr0n commented Aug 21, 2024

Hi! I also added fzf-lua and trouble.nvim. Trouble.nvim v4 had a big rewrite recently and a lot of new highlight groups have been added.

@echasnovski echasnovski changed the title Support for the listed plugins Add support for highlight groups of listed plugins Aug 22, 2024
@echasnovski
Copy link
Owner

Hi! I also added fzf-lua and trouble.nvim. Trouble.nvim v4 had a big rewrite recently and a lot of new highlight groups have been added.

What exactly you think is missing from 'folke/trouble.nvim' (which is already supported) and 'ibhagwan/fzf-lua' (which looks fine the last time I checked)?

@231tr0n
Copy link
Author

231tr0n commented Aug 22, 2024

Hi! I also added fzf-lua and trouble.nvim. Trouble.nvim v4 had a big rewrite recently and a lot of new highlight groups have been added.

What exactly you think is missing from 'folke/trouble.nvim' (which is already supported) and 'ibhagwan/fzf-lua' (which looks fine the last time I checked)?

Hi!
So the new trouble v4 with mini.base16 colorscheme and one dark color palette looks something like below. The icons are not properly shown:-
image

As per fzf-lua, there is no coloring in lsp_document_symbols and lsp_workspace_symbols.
image
There seems to be coloring for fzf-lua when using tokyonight.nvim.
image

@bassamsdata
Copy link

I believe this plugin render-markdown is well-established, given that it's been in development for over three months and has made its way into the default plugins of the LazyVim distro.

I use it daily with base16 module.

@echasnovski
Copy link
Owner

Thanks for the insight! I am afraid, both of these observations are not enough for me. Besides, "made its way into the default plugins of the LazyVim distro" is at least not accurate, as it is part of "Extra" for markdown language and is not "default" (which are arguably the ones included by default, i.e. 'mini.ai', 'mini.pairs', 'folke/lazy.nvim', 'folke/which-key.nvim', etc.).

@bassamsdata
Copy link

Thanks for the insight! I am afraid, both of these observations are not enough for me.

No worries at all.

as it is part of "Extra" for markdown language and is not "default"

That’s correct, it’s the default within the markdown language bundle under "Extra."

I apply those highlights every time I change themes, so it works just fine for me.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants