Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Ankaios cli command ank get agents #343

Merged
merged 80 commits into from
Aug 30, 2024
Merged

Add new Ankaios cli command ank get agents #343

merged 80 commits into from
Aug 30, 2024

Conversation

inf17101
Copy link
Contributor

@inf17101 inf17101 commented Aug 6, 2024 •
edited
Loading

Issues: #155

This PR covers:

  • Feature implementation in the server and the ank cli
  • Unifying the CLI table building to a single point of change => new table object "CliTable"
  • Swdd changes and new swdds
  • User documentation changes for: Chapter Working with CompleteState and introducing the new ank -k get agents command in a section inside the user tutorial
  • Extending a the utests and simplifying the utests for the table creator object
  • A system test for the ank -k get agents command

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

@inf17101 inf17101 self-assigned this Aug 6, 2024
inf17101 added 26 commits August 7, 2024 13:05
@inf17101
Fix utests
d1c1d1c
@inf17101
Write swdd reqs for the server
d50d19e
@inf17101
Implement storing and removing connected agents
eb059db
@inf17101
Revert to string for agent name and add basic utests
d1b12ac
@inf17101
Remove pub from workload_states_map entry
292ed51
@inf17101
Fix markdown newlines
0274358
@inf17101
Remove unused from in workload states map
7b526b1
@inf17101
Remove uncomment code
7be4c1f
@inf17101
Add connected agent utests in server
d7fba2d
@inf17101
Replace default with real agents values in utests
741bbfa
@inf17101
Make the AgentAttributes proto message empty
e2778e6
@inf17101
Fix rust analyzer warnings of previous PRs
ffca16f
@inf17101
Fix linkage in server utest
ae029bc
@inf17101
Revert agent_name.rs
a14c8f7
@inf17101
Swdd and linkage for agent map
d048428
@inf17101
Remove duplicated hashmap entry tests
a776f60
@inf17101
Change server state reqs
858f03c
@inf17101
Add agent map to cli filtered complete state
1ba7eb5
@inf17101
Implemented get agents logic in cli
40f9c30
@inf17101
Flatten agents map
3e64468
@inf17101
Change to into_keys
a2cb8f9
@inf17101
Refactored to table builder and refactor get_agents
78b1df1
@inf17101
Remove agent name clone
89c7f72
@inf17101
Remove row trait impls
6e1522c
@inf17101
Remove table builder complexity and fix utests
b80acce
@inf17101
Rename constant
8f86cac
@inf17101 inf17101 requested a review from krucod3 August 26, 2024 15:25
krucod3
krucod3 reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part of review done. Findings documented.
I'll continue with the rest of the review.

api/proto/ank_base.proto Outdated Show resolved Hide resolved
common/src/objects/agent_map.rs Show resolved Hide resolved
server/doc/swdesign/README.md Outdated Show resolved Hide resolved
server/doc/swdesign/README.md Outdated Show resolved Hide resolved
server/doc/swdesign/README.md Show resolved Hide resolved
ank/doc/swdesign/README.md Outdated Show resolved Hide resolved
ank/src/cli_commands/cli_table.rs Outdated Show resolved Hide resolved
ank/src/cli_commands/cli_table.rs Outdated Show resolved Hide resolved
ank/src/cli_commands/cli_table.rs Outdated Show resolved Hide resolved
ank/src/cli_commands/cli_table.rs Outdated Show resolved Hide resolved
inf17101 and others added 12 commits August 29, 2024 11:28
@inf17101 @krucod3
Change agent proto field comment
eb84716 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Remove duplicated swdd prefix
6ce1b25 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Remove duplicated swdd prefix
421729b 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101
Increment req id of complete state content
7848dab
@inf17101 @krucod3
Remove 'part' word of req
029eff5 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101
Exclude agent_map from test coverage
f5a1b65
@inf17101 @krucod3
Remove 'part' word of req
03bb0e0 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Change comment in stest
d215a5e 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Add commas to req
f3273f8 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Change req wording
50af9e2 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Switch to one liner
72099d4 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101
Move table_width call
53330e4
krucod3
krucod3 reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done, findings documented.

ank/doc/swdesign/plantuml/seq_get_agent.plantuml Show resolved Hide resolved
ank/doc/swdesign/plantuml/seq_get_agent.plantuml Outdated Show resolved Hide resolved
ank/doc/swdesign/plantuml/seq_get_agent.plantuml Outdated Show resolved Hide resolved
ank/doc/swdesign/plantuml/seq_get_agent.plantuml Outdated Show resolved Hide resolved
tools/generate_test_coverage_report.sh Outdated Show resolved Hide resolved
krucod3
krucod3 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

inf17101 and others added 2 commits August 30, 2024 11:14
@inf17101
Remove swdd duplicated prefix
b8833e3
@inf17101 @krucod3
Switch to unchecked addition
75352f4 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 inf17101 merged commit 0f82899 into main Aug 30, 2024
10 checks passed
@inf17101 inf17101 deleted the 155_list_agents branch August 30, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krucod3 krucod3 krucod3 approved these changes

Assignees

@inf17101 inf17101

Labels
enhancement New feature or request. Issue will appear in the change log "Features"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inf17101 @krucod3