Re-use bundles at startup for podman runtime #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All done. Ready for review. |
windsource
added
enhancement
|
Currently this PR only handles agent restart and reuses containers that have the same configuration and are in state succeeded. But he agent might also restart workloads with |
|
Should we create a ticket for the restarts? We can then add the constrains in (e.g., only for successfully finished workloads). |
|
@krucod3 At first I thought about adding this right in this PR but we can also review it like it is today and have another isssue + PR for the restart policy. |
3 tasks
krucod3
reviewed
Oct 22, 2024
tests/resources/configs/device_restart_with_dependencies_modified.yaml
Outdated
Show resolved
Hide resolved
agent/src/runtime_connectors/podman_kube/podman_kube_runtime.rs
Outdated
Show resolved
Hide resolved
|
Fixed review findings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue-Id: #260
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.