Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Terminal API doesn't work for a plugin running in a sidecar container #112

Closed
azatsarynnyy opened this issue Mar 15, 2019 · 1 comment
Closed
Assignees
Labels
kind/bug Something isn't working

Comments

@azatsarynnyy
Copy link
Member

Description

Theia Plugin Terminal API doesn't work for a plugin running in a sidecar container.

Reproduction Steps

1/ Start Che Workspace with the terminal-plugin sample running in its own container.
Use the DevFile:

specVersion: 0.0.1
name: terminal-sample
tools:
  - name: theia-ide
    type: cheEditor
    id: org.eclipse.che.editor.theia:1.0.0
  - name: exec-plugin
    type: chePlugin
    id: che-machine-exec-plugin:0.0.1
  - name: terminal-sample-plugin
    type: chePlugin
    id: https://raw.githubusercontent.com/azatsarynnyy/che7-plugin-registry/master/terminal-sample:0.0.1

2/ Call the Send text to the terminal command from Theia Command Palette.

Expected behavior:

New Terminal is created and text is printed to the terminal
image

Diagnostics:

from browser's console:

Uncaught (in promise) TypeError: Cannot read property 'proxy' of undefined
    at TerminalServiceExtImpl.createTerminal (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/terminal-ext.js:77)
    at TerminalServiceExtImpl.createTerminal (/home/theia/lib/node/terminal-container-aware.js:43)
    at Object.createTerminal (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:299)
    at createTerminalWithOptions (/plugins/terminal-sample.0.0.1/lib/new-terminal-backend.js:262)
    at /plugins/terminal-sample.0.0.1/lib/new-terminal-backend.js:106
    at /home/theia/node_modules/@theia/plugin-ext/lib/plugin/command-registry.js:113
    at CommandRegistryImpl.executeLocalCommand (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/command-registry.js:165)
    at CommandRegistryImpl.$executeCommand (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/command-registry.js:130)
    at RPCProtocolImpl.doInvokeHandler (/home/theia/node_modules/@theia/plugin-ext/lib/api/rpc-protocol.js:175)
    at RPCProtocolImpl.invokeHandler (/home/theia/node_modules/@theia/plugin-ext/lib/api/rpc-protocol.js:160)
@azatsarynnyy azatsarynnyy added the kind/bug Something isn't working label Mar 15, 2019
@azatsarynnyy
Copy link
Member Author

It's critical for running the Kubernetes Tooling Che Plugin since a lot of the plugin's commands depend on Terminal API.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants