Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang Plugin #12145

Closed
tsmaeder opened this issue Dec 7, 2018 · 9 comments
Closed

Golang Plugin #12145

tsmaeder opened this issue Dec 7, 2018 · 9 comments
Assignees

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Dec 7, 2018

We'd like to have Golang support in Che 7. There is a Golang plugin for VSCode. We should investigate whether we can run the Golang plugin in Theia as it exists now.
As we currently don't have a plugin broker for vscode plugins (@garagatyi is currently working on it), we should start by evaluating the vscode golang plugin.

  1. Test language server functions
  2. Test debugger functionality
  3. Evaluate debugger in view of running it in a sidecar: can we debug a process running in the target container?

If at this point, we have a working plugin broker for vscode plugins, we can start to develop the che plugin, otherwise, there is a way to repackage a vscode plugin to make it work as a che plugin (@benoitf knows how). In order to run as a che plugin, we need to

  1. Create or find a container that can run the vscode golang plugin
  2. Package the vscode plugin & container as a che-7 plugin and publish to the plugin registry
@tolusha
Copy link
Contributor

tolusha commented Feb 15, 2019

eclipse-theia/theia#4070

@benoitf
Copy link
Contributor

benoitf commented Feb 20, 2019

hello @tolusha
As CQ is blocked for tmate file

Couldn't we just use https://marketplace.visualstudio.com/items?itemName=dunstontc.vscode-go-syntax to provide go syntax highlight and then your PR on theia would be only on fixes. No duplicated code.

@tolusha
Copy link
Contributor

tolusha commented Feb 21, 2019

@benoitf
Great. Make sense. I will try.

@tolusha
Copy link
Contributor

tolusha commented Feb 21, 2019

Unfortunately they conflict with each other in term of language contribution.

@tolusha
Copy link
Contributor

tolusha commented Feb 21, 2019

I can try to merge both extensions and host a custom one in our repository [1] like I did for typescript [2]

[1] https://github.com/che-incubator/
[2] https://github.com/che-incubator/ms-code.typescript

@benoitf WDYT ?

@benoitf
Copy link
Contributor

benoitf commented Feb 21, 2019

@tolusha yes you can.

do you know if the conflict is a theia issue or not (is it working on VsCode ?)

@tolusha
Copy link
Contributor

tolusha commented Feb 21, 2019

Another option is to provide GO lang functionality without syntax highlighting.

@tolusha
Copy link
Contributor

tolusha commented Feb 21, 2019

It works in VS Code.

@benoitf
Copy link
Contributor

benoitf commented Feb 21, 2019

@tolusha would be a good start as well (better than nothing) and then we can fix theia to handle the two extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants