Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traces/metrics relate to routes #12699

Closed
skabashnyuk opened this issue Feb 19, 2019 · 7 comments
Closed

Add traces/metrics relate to routes #12699

skabashnyuk opened this issue Feb 19, 2019 · 7 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@skabashnyuk
Copy link
Contributor

Description

We would like to observe how routes creation is happening.
Related issue openshiftio/openshift.io#4730

@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform labels Feb 19, 2019
@garagatyi
Copy link

Can you clarify what do you mean by metrics for routes?
BTW we already have traces for routes creation here https://github.com/eclipse/che/blob/master/infrastructures/openshift/src/main/java/org/eclipse/che/workspace/infrastructure/openshift/OpenShiftInternalRuntime.java#L176
Did you mean traces for routes availability?

@sleshchenko
Copy link
Member

@garagatyi Do you happen to know how routes availability can be checked? I mean maybe status is not set for an unavailable route?

@skabashnyuk
Copy link
Contributor Author

I need some time to clarify this task. Basically, I want to see some routes related metric that will mean something for the user. Not only API call. May be we need something that will ensure that route really created.

@garagatyi
Copy link

@sleshchenko we could add traces programatically when we ping servers. We could also try to use https://docs.openshift.com/container-platform/3.5/rest_api/openshift_v1.html#list-or-watch-objects-of-kind-route, but I'm not sure it shows flaky routes

@fche
Copy link

fche commented Feb 20, 2019

@skabashnyuk It sounds a little like what you need is some metric from the openshift infrastructure, in the form of latencies for a complete operation (route CRD creation through to actual operation).

@skabashnyuk
Copy link
Contributor Author

closing in prefer of #12740

@skabashnyuk skabashnyuk reopened this Feb 22, 2019
@skabashnyuk skabashnyuk added the severity/P2 Has a minor but important impact to the usage or development of the system. label Mar 6, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants