Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia should be the default editor #12835

Closed
l0rd opened this issue Mar 6, 2019 · 4 comments
Closed

Theia should be the default editor #12835

l0rd opened this issue Mar 6, 2019 · 4 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Mar 6, 2019

Description

When a user defines a Che 7 workspace (using a devfile, a workspace json or a stack) he needs to specify the editor. Otherwise, if no tools are defined, he gets the following error:

{
  "message": "Devfile schema validation failed. Error: /devfile object has missing required properties ([\"tools\"])"
}

and, if at least a tool is defined, the workspace is created but the execution fails (wsagent server doesn't exist):

image

Most of the users will only want to use the default editor (che-theia) and we should make it possible to use a devfile without a theia-editor and without tools.

In addition, if the editor is Theia, the exec-plugin should be loaded by default:

For instance a user should be able to use the following devfile

specVersion: 0.0.1
name: petclinic-dev-environment
projects:
  - name: petclinic
    source:
      type: git
      location: 'git@github.com:spring-projects/spring-petclinic.git'

and it should be equivalent to

---
specVersion: 0.0.1
name: petclinic-dev-environment
projects:
  - name: petclinic
    source:
      type: git
      location: 'git@github.com:spring-projects/spring-petclinic.git'
tools:
  - name: theia-editor
    type: cheEditor
    id: org.eclipse.che.editor.theia:1.0.0
  - name: exec-plugin
    type: chePlugin
    id: che-machine-exec-plugin:0.0.1
@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Mar 6, 2019
@benoitf
Copy link
Contributor

benoitf commented Mar 6, 2019

@l0rd how to differentiate someone who really want no editor and someone that want the default in the devfile ?

@skabashnyuk skabashnyuk added team/platform severity/P1 Has a major impact to usage or development of the system. labels Mar 6, 2019
@l0rd
Copy link
Contributor Author

l0rd commented Mar 6, 2019

@benoitf I never thought about supporting workspace without editor. What that for?

Anyway I think that we can agree that most of users will want Theia hence it should be the default: if a user want an editor-free workspace he will need to specify it explicitly (e.g. with an attribute like editorFree: true or specifying a particular cheEditor with id: empty-editor).

@benoitf
Copy link
Contributor

benoitf commented Mar 6, 2019

@l0rd let say I just want headless containers. Like deploying my application without the need to develop it :-)

@garagatyi
Copy link

What if user starts workspace for application deployment/check but develops in a desktop IDE and syncs files to the workspace? Seems like a case for a headless workspace.

@sleshchenko sleshchenko self-assigned this Mar 28, 2019
@sleshchenko sleshchenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 28, 2019
@sleshchenko sleshchenko removed the status/in-progress This issue has been taken by an engineer and is under active development. label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants