Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard build is successful even when typescript compilation failed #12902

Closed
ljelinkova opened this issue Mar 15, 2019 · 1 comment
Closed

Dashboard build is successful even when typescript compilation failed #12902

ljelinkova opened this issue Mar 15, 2019 · 1 comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ljelinkova
Copy link
Contributor

ljelinkova commented Mar 15, 2019 •
edited
Loading

Description

When I have some typescript error and run gulp build, the build is successful but it should fail.

Reproduction Steps

  1. Open any .ts file in the dashboard/src/app and modify it so that it does not compile
  2. Run gulp build
  3. RESULT: you can see many errors in log but the script is successful

This issue is related to #12825. While #12825 addresses that errors should be resolved, this one addresses the fact that the script should fail in case such errors occur.
@ljelinkova ljelinkova mentioned this issue Mar 18, 2019
Merged
@monaka monaka added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 21, 2019
@monaka monaka mentioned this issue Apr 22, 2019
Closed
@che-bot
Copy link
Contributor

che-bot commented Sep 17, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 17, 2019
@che-bot che-bot closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@monaka @ljelinkova @che-bot