Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building and running applications at workspace start with devfile v2 post start events #12925

Closed
slemeur opened this issue Mar 19, 2019 · 24 comments
Labels
area/devfile-spec Issues related to Devfile v2 area/devworkspace-operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. roadmap/6-months Epics that are planned to complete in the medium term (within 6 months) severity/P1 Has a major impact to usage or development of the system.

Comments

@slemeur
Copy link
Contributor

slemeur commented Mar 19, 2019

Description

We are now relying on devfile for the factory flow.

Factories are providing extended capabilities, allowing post-loading actions to open file, start a command.
We should be able to extend the devfile to allow a user to define those actions.

We should also make sure that users will be able to define factories with a devfile (and extended meta-datas). JSON, even if used internally by WSMaster would not be exposed anymore to the end-user.

User Stories

In the dashboard, when the user is editing the definition of a factory, it must be based on the devfile format.

  • In the dashboard, a user should be able to create a factory by providing a devfile and defining the extended meta-datas.
  • In the dashboard, a user should be able to create a factory from an existing workspace.

(In other words, whereever we are displaying the factory.json configuration in the dashboard, it should be replaced by devfile)

Implementation

@slemeur slemeur added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. team/platform labels Mar 19, 2019
@l0rd l0rd mentioned this issue Mar 19, 2019
@skabashnyuk skabashnyuk added the severity/P1 Has a major impact to usage or development of the system. label Apr 2, 2019
@skabashnyuk
Copy link
Contributor

@slemeur is this issue still in our GA plan? Are we going to support persistent factories in Che7 era?

@skabashnyuk
Copy link
Contributor

@l0rd wdyt? can we remove GA label?

@l0rd l0rd removed the target/che7GA label Jun 5, 2019
@l0rd
Copy link
Contributor

l0rd commented Jun 5, 2019

@skabashnyuk removed

@matthewfisch
Copy link

matthewfisch commented Jul 24, 2020

What the heck team? Is this still broken? I just wasted over an hour trying to get factories working and then stumbled on this. ++ for just removing functionality that's totally broken and can't work.

So .... users can't share workspaces any other way, only copy/paste devfiles right?

@sleshchenko
Copy link
Member

@matthewfisch In addition to copying/pasting devfiles, there is available factory flow, where users are able to host devfile somewhere, like git repo, and then just provide a link to create a workspace, like
to github repo https://che.openshift.io/f?url=http://github.com/eclipse/che
or devfile content https://che.openshift.io/f?url=https://raw.githubusercontent.com/eclipse/che/master/devfile.yaml

There is also an issue where you can track adding new feature - users devfile, in a few words - Che will allow to host devfiles for further sharing #16875.

@matthewfisch
Copy link

I am heartened that I can still use the factory flow using devfile.yaml .... but I don't understand why there's a broken factories screen. Is there any way it should work?

@veeramanikandanvv
Copy link

I am not able to create factories in eclipse che 7.17.0. I am not seeing any workspaces listed when we try to create factories out of of workspaces. Application displays error messages as - this factory is using old workspace definition. I am not able to see any documentation to update the factory runtime configuration.
Eclipse che 7.17.0, multiuser, single host.
Installed via helm on kubernetes. Please help me on this issue

@skabashnyuk
Copy link
Contributor

@veeramanikandanvv persisted factories are not implemented in Che7 . Similar logic would be implemented as User devfiles #16875

@sunix sunix added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Sep 1, 2020
@sunix
Copy link
Contributor

sunix commented Sep 1, 2020

setting back to p1.
So be able to add at least che-task and theia command to start automatically when the workspace is open

@sleshchenko
Copy link
Member

removing dashboard and controller since it's more about devfile/v1. Once it's implemented via spec - we can think how to use that in Che Theia and Dashboard.

@skabashnyuk skabashnyuk removed this from the Backlog - Platform milestone Oct 1, 2020
@l0rd l0rd added roadmap/6-months Epics that are planned to complete in the medium term (within 6 months) area/devfile-spec Issues related to Devfile v2 engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/devworkspace-operator and removed area/devfile/v1 labels Mar 26, 2021
@l0rd l0rd changed the title Add post-loading actions to devfile spec Allow building and running applications at workspace start with devfile v2 post start events Mar 30, 2021
@che-bot
Copy link
Contributor

che-bot commented Oct 12, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2021
@l0rd
Copy link
Contributor

l0rd commented Oct 12, 2021

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2021
@che-bot
Copy link
Contributor

che-bot commented Apr 10, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2022
@che-bot che-bot closed this as completed Apr 17, 2022
@l0rd
Copy link
Contributor

l0rd commented Apr 21, 2022

Should be fixed by devfile/devworkspace-operator#659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues related to Devfile v2 area/devworkspace-operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. roadmap/6-months Epics that are planned to complete in the medium term (within 6 months) severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests