Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che 7 stacks should use version "latest" of plugins #13426

Closed
l0rd opened this issue May 27, 2019 · 4 comments
Closed

Che 7 stacks should use version "latest" of plugins #13426

l0rd opened this issue May 27, 2019 · 4 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented May 27, 2019

Description

That's about updating the devfiles in the che-devfile-registry to use version latest of the plugins. That's important for at least the following reasons:

  • Users will expect that the latest and greatest versions of the plugins are used in the default stacks
  • We don't want to update the stacks everytime there is a new version of a plugin
  • We should test our stacks against the latest versions of plugin as soon as possible (fail fast)
@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. team/platform labels May 27, 2019
@skabashnyuk skabashnyuk added the severity/P1 Has a major impact to usage or development of the system. label Jun 6, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Jun 11, 2019

@l0rd @skabashnyuk just to make sure we are on the same page with this task. Atm, there is a script [1] for the latest folder (version) generation on the plugin registry side and it is expected that "latest" version would be defined explicitly in the plugins attribute. The PR [2] for falling back on the "latest" version if no version is specified was considered to be optional for Che 7 GA since it was highly-conflicting with #13297

Please, comment if there are any concerns with the current approach

[1] https://github.com/eclipse/che-plugin-registry/blob/master/scripts/setup_latest_dirs.sh
[2] #13414

@mshaposhnik
Copy link
Contributor

mshaposhnik commented Jun 11, 2019

#13297 is merged so i see no much problems to rebase #13414 on top of it (it even should became simpler)

@ibuziuk
Copy link
Member

ibuziuk commented Jun 11, 2019

we can potentially take it to the next sprint and try to finalize by GA, but our capacity is pretty low atm, so it mainly matter of priority. @l0rd wdyt should we work on finalization of #13414 in the upcoming sprint or can we postpone it after GA + potentially improve the parsing of the attributes to make is less error-prone - #13385 ?

@l0rd
Copy link
Contributor Author

l0rd commented Jun 11, 2019

@ibuziuk let's postpone after GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants