Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

che factory: should be able to override the name, source.repo, source.branch of the workspace that will be created in the url #13617

Closed
sunix opened this issue Jun 21, 2019 · 5 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone

Comments

@sunix
Copy link
Contributor

sunix commented Jun 21, 2019

Description

At the moment when creating a workpace from a devfile, we can use the factory url

For instance: https://che.openshift.io/f?url=https://github.com/eclipse/che-website will create a workspace from the devfile.yaml located in the repo and the workspace name will be generated from the one in the devfile: che-website.

If a workspace name already exists, it will suffix it with _1, _2, etc ... these name would become unusable for the user who would have to deal with dozen of workspace with the same name.

The goal of the issue is to add a new parameter in the query name:
https://che.openshift.io/f?url=https://github.com/eclipse/che-website&metadata.name=website-work-on-technology-section
would create a new workspace and name it website-work-on-technology-section

We could also add parameters like projects.projectname.source.location and projects.projectname.source.branch to override git location and branch

@sunix sunix added the kind/enhancement A feature request - must adhere to the feature request template. label Jun 21, 2019
@sunix sunix changed the title che factory: should be able to override the name of the workspace that will be created in the url che factory: should be able to override the name, source.repo, source.branch of the workspace that will be created in the url Jun 26, 2019
@sunix sunix added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 29, 2019
@benoitf benoitf added status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. team/platform and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 5, 2019
@benoitf benoitf added this to the 7.3.0 milestone Aug 5, 2019
@benoitf benoitf added the severity/P2 Has a minor but important impact to the usage or development of the system. label Aug 5, 2019
@benoitf
Copy link
Contributor

benoitf commented Aug 5, 2019

@skabashnyuk Do you have feedback/thoughts on this improvement ?

@skabashnyuk
Copy link
Contributor

Nice new feature. Why it's set only as p2 and set to 7.3.0?

@benoitf
Copy link
Contributor

benoitf commented Aug 5, 2019

@skabashnyuk no previous triagers looked at this issue before so I was thinking it was not so important.
I think scope of 7.1.0 has lot of issues so I was thinking 7.2.0 or 7.3.0

About severity I used P2 as it's an advanced usecase.

@skabashnyuk do you have empty room for 7.2.0 and then we move it for 7.2.0 ?

@sunix
Copy link
Contributor Author

sunix commented Sep 16, 2019

To me this is very important, for example if you want to share a link to a PR: could provide the default devfile.yaml but override the branch.

@sunix sunix added status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. and removed status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. labels Sep 16, 2019
@benoitf benoitf removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 18, 2019
@skabashnyuk skabashnyuk modified the milestones: 7.3.0, 7.x Sep 26, 2019
@skabashnyuk skabashnyuk modified the milestones: 7.x, Backlog - Platform Oct 10, 2019
@skabashnyuk skabashnyuk modified the milestones: Backlog - Platform, 7.5.0 Nov 7, 2019
@mshaposhnik
Copy link
Contributor

Both code & docs PR merged, happy using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

4 participants