Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons aren't displayed on a contributed view container #13750

Closed
azatsarynnyy opened this issue Jun 12, 2019 · 7 comments · Fixed by eclipse-che/che-theia#430
Closed

Icons aren't displayed on a contributed view container #13750

azatsarynnyy opened this issue Jun 12, 2019 · 7 comments · Fixed by eclipse-che/che-theia#430
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@azatsarynnyy
Copy link
Member

If Theia Plugin, running in a sidecar, contributes a view container with the icons they are not displayed anymore.

For example, Kubernetes Tooling Che Plugin contributes view container that was looking like that
57142979-7f683a00-6dc6-11e9-95d9-1fa0e436ff90

But now there are no icons. Neither for view container nor for the tree items

image

I noticed that icons are displayed correctly if I install VS Code extension from the marketplace with the Deploy Plugin by Id command directly into the Theia container.

@sunix
Copy link
Contributor

sunix commented Jun 12, 2019

anything in the browser log ?

@azatsarynnyy
Copy link
Member Author

image

it fails to load an icon for displaying on activity bar

The link is the following
http://server46zcwvmn-theia-ideq14-server-3100.192.168.99.251.nip.io/hostedPlugin/ms_kubernetes_tools_vscode_kubernetes_tools/images%2Flogo.svg

If VS Code extension installed in a Theia container, the link looks the same but it returns an icon.

@mmorhun
Copy link
Contributor

mmorhun commented Jun 13, 2019

@azatsarynnyy isn't it issue for Theia?

@azatsarynnyy
Copy link
Member Author

@mmorhun it works well in Theia

@benoitf benoitf transferred this issue from eclipse-che/che-theia Jul 5, 2019
@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. labels Jul 5, 2019
@evidolob
Copy link
Contributor

It looks like we don't configure express application and don't follow BackendApplicationContribution Theia contribution. Theia has REST service for plugin resources but in theia-remout we not initialize it.

@vparfonov vparfonov added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 2, 2019
@vparfonov
Copy link
Contributor

@slemeur Can you take a lock on this issue and prioritize it

@benoitf benoitf added this to the 7.1.0 milestone Aug 5, 2019
@benoitf benoitf added team/ide and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 5, 2019
@mmorhun mmorhun self-assigned this Aug 16, 2019
@l0rd l0rd added the severity/P1 Has a major impact to usage or development of the system. label Aug 29, 2019
@sunix sunix added the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 4, 2019
@mmorhun mmorhun removed the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 10, 2019
@mmorhun
Copy link
Contributor

mmorhun commented Sep 10, 2019

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
7 participants