Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree nodes don't expand in the GitHub plugin #13790

Closed
vinokurig opened this issue Jul 8, 2019 · 4 comments · Fixed by eclipse-theia/theia#5661
Closed

Tree nodes don't expand in the GitHub plugin #13790

vinokurig opened this issue Jul 8, 2019 · 4 comments · Fixed by eclipse-theia/theia#5661
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/next
Milestone
7.1.0

Comments

@vinokurig
Copy link
Contributor

Description

Tree nodes don't expand in the GitHub plugin

Reproduction Steps

  1. Enable Github PR plugin in the plugins list of the workspace
  2. Open a workspace with Github project with pull requests
  3. Try to expand a PR node

Wrong: Node is not expanded:
screenshot-localhost-3030-2019 07 08-12-15-42
Error is occurred:

root ERROR [hosted-plugin: 27890] (node:27890) UnhandledPromiseRejectionWarning: TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at Function.MessageFactory.replyOK (/home/ivinokur/projects/theia/packages/plugin-ext/lib/api/rpc-protocol.js:280:103)
    at /home/ivinokur/projects/theia/packages/plugin-ext/lib/api/rpc-protocol.js:158:51
root ERROR [hosted-plugin: 27890] (node:27890) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 9)

OS and version:
7.0.0-rc-3.0
Diagnostics:
@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. area/editor/theia Issues related to the che-theia IDE of Che labels Jul 8, 2019
@vinokurig vinokurig mentioned this issue Jul 8, 2019
Merged
1 task
@l0rd l0rd added the team/ide label Jul 8, 2019
@l0rd l0rd added this to the 7.1.0 milestone Jul 8, 2019
@l0rd l0rd added the severity/P2 Has a minor but important impact to the usage or development of the system. label Jul 8, 2019
@l0rd
Copy link
Contributor

l0rd commented Jul 8, 2019

I don't consider that as a blocker for GA. I have put 7.1.0 as milestone. cc @slemeur

@vinokurig vinokurig reopened this Aug 13, 2019
@vinokurig
Copy link
Contributor Author

Is actual for 7.0.0-next tag

@vparfonov vparfonov mentioned this issue Aug 20, 2019
Closed
19 tasks
@l0rd
Copy link
Contributor

l0rd commented Aug 29, 2019

@vinokurig can we close that now since it was fixed in theia master branch right?

@vinokurig
Copy link
Contributor Author

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/next
Projects
None yet
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

Fix Converting circular structure to JSON Error in tree-view eclipse-theia/theia
3 participants
@l0rd @vparfonov @vinokurig