Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin eclipse/che-theia/latest is not using the right definition #13859

Closed
sunix opened this issue Jul 16, 2019 · 10 comments
Closed

plugin eclipse/che-theia/latest is not using the right definition #13859

sunix opened this issue Jul 16, 2019 · 10 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.

Comments

@sunix
Copy link
Contributor

sunix commented Jul 16, 2019

Describe the bug

eclipse/che-theia/latest/meta.yaml

and

eclipse/che-theia/7.0.0-rc-3.0/meta.yaml

are different (for instance see the exposed ports and endpoints)
latest should be using one the tagged version.

The result of this is that eclipse/che-theia/latest cannot use the theia port plugin and user have to add port to expose manually in the devfile.

latest should be the same as one of the released versions at least.

@sunix sunix added area/editor/theia Issues related to the che-theia IDE of Che area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. labels Jul 16, 2019
@l0rd
Copy link
Contributor

l0rd commented Jul 16, 2019

It looks to me that

  • next: che-theia latest commit
  • latest: che-theia latest stable version
  • x.y.z: che-theia specific stable version

So yes I think you are right @sunix. The fix here should to update eclipse/che-theia/latest to match clipse/che-theia/7.0.0-rc-3.0? That's something that may be addressed in eclipse-che/che-plugin-registry#183.

cc @benoitf @evidolob @vparfonov

@l0rd l0rd added the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Jul 16, 2019
@sunix
Copy link
Contributor Author

sunix commented Jul 17, 2019

@amisevsk
Copy link
Contributor

Also from the ./scripts/setup_latest_dirs.sh script:

Working on directory: v3/plugins/eclipse/che-theia
  WARN: Found newer meta.yaml in  v3/plugins/eclipse/che-theia/next/meta.yaml
        No changes are made, but ensure the correct version is in 'latest'
Working on directory: v3/plugins/ms-kubernetes-tools/vscode-kubernetes-tools
  WARN: Found newer meta.yaml in  v3/plugins/ms-kubernetes-tools/vscode-kubernetes-tools/1.0.0/meta.yaml
        No changes are made, but ensure the correct version is in 'latest'
Working on directory: v3/plugins/redhat/vscode-openshift-connector
  WARN: Found newer meta.yaml in  v3/plugins/redhat/vscode-openshift-connector/0.0.21/meta.yaml
        No changes are made, but ensure the correct version is in 'latest'
Working on directory: v3/plugins/redhat/vscode-xml
  WARN: Found newer meta.yaml in  v3/plugins/redhat/vscode-xml/0.7.0/meta.yaml
        No changes are made, but ensure the correct version is in 'latest'

Double checking these there are a few small differences from latest (e.g. vscode-kubernetes-tools does not specify a memory limit in latest); the script may also be slightly out of date in how it does comparison.

@amisevsk
Copy link
Contributor

(Most of these inconsistencies are due to firstPublicationDate not matching.

@sunix
Copy link
Contributor Author

sunix commented Jul 17, 2019

would symbolic links work with the registry ?

@l0rd
Copy link
Contributor

l0rd commented Jul 17, 2019

@sunix we have discussed with @vparfonov about this earlier today. You are right and we have updated the release procedure with a new step to fix this problem. But that's really not a big deal: who is using che-theia:latest?.

@sunix
Copy link
Contributor Author

sunix commented Jul 17, 2019

Well I use that one on che.openshift.io to test the stable release and not having to change the version at each release.

@amisevsk
Copy link
Contributor

@sunix regarding symbolic links:

I tried that initially in implementing latest versions, but it comes with a few issues (most notable of which is that it results in the latest version being shown twice since there are two metas with that version).

There is more discussion in the original PR: eclipse-che/che-plugin-registry#143

@che-bot
Copy link
Contributor

che-bot commented Jan 15, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2020
@amisevsk
Copy link
Contributor

Issue is out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.
Projects
None yet
Development

No branches or pull requests

4 participants