Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registries MemoryLimit is too low and deployment fails on OpenShift #14093

Closed
l0rd opened this issue Aug 1, 2019 · 7 comments
Closed

Registries MemoryLimit is too low and deployment fails on OpenShift #14093

l0rd opened this issue Aug 1, 2019 · 7 comments
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Aug 1, 2019

Describe the bug

Currently the memory max limits for the plugin and devfile pods are set to 32Mi. On some OpenShift clusters that is not allowed: the minimum is 256Mi.

Che version

7.0.0-rc-4.0

Steps to reproduce

Use the operatorhub to deploy Che on openshift online

Expected behavior

Che is deployed

Runtime

OS 4

Installation method

OperatorHub

Environment

Cloud: openshiftworkshop.com

@l0rd l0rd added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator team/platform labels Aug 1, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@skabashnyuk
Copy link
Contributor

Can we set a limit to 0? WDYT?

@l0rd
Copy link
Contributor Author

l0rd commented Aug 1, 2019

Discussing with @davidfestal that has debugged the problem it looks like the solution would be to set memory request to 16Mi and limit to 256Mi.

@skabashnyuk I am not sure that this should be fixed Helm side as well (since it's an OpenShift specific problem) but it maybe a good idea to keep consistency on both installers (i.e. it's not a blocker).

@davidfestal
Copy link
Contributor

More precisely the idea is the keep the memory request (= min memory) to 16Mi, but increase the memory limit (= max memory) to 256Mi to satisfy a common Openshift cluster configuration.

@davidfestal
Copy link
Contributor

So +1 to do that for Openshift only at first.

@l0rd l0rd added the team/osio label Aug 1, 2019
@ibuziuk ibuziuk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@ibuziuk ibuziuk modified the milestones: 7.1.0, 7.0.0 Aug 1, 2019
@skabashnyuk
Copy link
Contributor

Removed team/platform since helm is not in the scope

@skabashnyuk skabashnyuk removed their assignment Aug 1, 2019
@l0rd
Copy link
Contributor Author

l0rd commented Aug 2, 2019

@skabashnyuk as I said in the comment above helm and operator should be consistent. Helm is in scope by the helm part is not a blocker. You can create a new issue about that or use this one and re-apply your team label

@ibuziuk
Copy link
Member

ibuziuk commented Aug 5, 2019

PR merged - eclipse-che/che-operator#64
Should be fixed with the next operator release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

5 participants