Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chectl: --domain is ignored if minikube/minishift platform is enabled #14095

Closed
7 of 23 tasks
sleshchenko opened this issue Aug 1, 2019 · 3 comments
Closed
7 of 23 tasks

chectl: --domain is ignored if minikube/minishift platform is enabled #14095

sleshchenko opened this issue Aug 1, 2019 · 3 comments
Labels
area/chectl Issues related to chectl, the CLI of Che severity/P1 Has a major impact to usage or development of the system.
Milestone
7.0.0

Comments

@sleshchenko
Copy link
Member

Describe the bug

I configured domain on DNS server to point to my virtual box IP, but chectl ignores --domain and use minishift/minikube ip + nip.io

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Execute
chectl server:start --installer=operator --platform=minikube --tls --multiuser --domain=test.com
  1. Check the logs that chectl computes domain automatically and overrides user-defined.

Expected behavior

test.com is used as ingress domain

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Screenshot_20190801_154956

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context
@sleshchenko sleshchenko mentioned this issue Aug 1, 2019
Merged
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Aug 1, 2019

@sleshchenko this looks like not crutial for GA, moving to 7.1.0

@ibuziuk ibuziuk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@ibuziuk ibuziuk added this to the 7.1.0 milestone Aug 1, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@benoitf benoitf removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Aug 1, 2019

oh, I see PR already sent - che-incubator/chectl#239

@ibuziuk ibuziuk modified the milestones: 7.1.0, 7.0.0 Aug 1, 2019
@ibuziuk ibuziuk added area/chectl Issues related to chectl, the CLI of Che severity/P1 Has a major impact to usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Aug 1, 2019
@sleshchenko
Copy link
Member Author

Should be fixed by che-incubator/chectl#239

@sleshchenko sleshchenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/chectl Issues related to chectl, the CLI of Che severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
4 participants
@benoitf @ibuziuk @sleshchenko @che-bot