Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[che-theia] build of docker images should not make GITHUB_TOKEN mandatory #14194

Closed
benoitf opened this issue Aug 12, 2019 · 0 comments · Fixed by eclipse-che/che-theia#434
Closed
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@benoitf
Copy link
Contributor

benoitf commented Aug 12, 2019

Is your enhancement related to a problem? Please describe.

When building docker images of Theia, GITHUB_TOKEN is a required parameter of the build script while it shouldn't
For now this parameter is mandatory. Not providing it through ./build.sh --build-arg GITHUB_TOKEN=.... is making the build always fail. It should be an optional parameter that should be mandatory only if we're forced to provide it because for example we share a network with other ppl making a lot of github requests.

Describe the solution you'd like

Be able to build the images without this token.

Also for now the check on a github rate limit is done inside the dockerfile. We should probably move out this code to the build script.

Describe alternatives you've considered

Additional context

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che labels Aug 12, 2019
@benoitf benoitf added this to the 7.1.0 milestone Aug 12, 2019
@sunix sunix modified the milestones: 7.1.0, 7.2.0 Sep 4, 2019
@mmorhun mmorhun self-assigned this Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants