Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Welcome plugin uses absolute paths to reference page elements #14233

Closed
metlos opened this issue Aug 14, 2019 · 4 comments
Closed

Welcome plugin uses absolute paths to reference page elements #14233

metlos opened this issue Aug 14, 2019 · 4 comments
Assignees
@mmorhun
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.2.0

Comments

@metlos
Copy link
Contributor

metlos commented Aug 14, 2019 •
edited
Loading

The welcome plugin generates links to the elements on the page using an absolute path (for example here: https://github.com/eclipse/che-theia/blob/master/plugins/welcome-plugin/src/welcome-page.ts#L30).

This leads to the page being broken in the single-host or default-host server strategy where such URLs become invalid (because the workspace itself is deployed on a subpath instead of in the root path of a subdomain).
@metlos metlos added the area/editor/theia Issues related to the che-theia IDE of Che label Aug 14, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 14, 2019
@slemeur slemeur added kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 14, 2019
@slemeur
Copy link
Contributor

slemeur commented Aug 14, 2019

needed for: #14189

@slemeur slemeur added this to the 7.1.0 milestone Aug 14, 2019
@slemeur slemeur added team/ide2 and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 14, 2019
@slemeur slemeur modified the milestones: 7.1.0, 7.2.0 Aug 21, 2019
@evidolob evidolob mentioned this issue Aug 28, 2019
Closed
20 tasks
@mmorhun mmorhun self-assigned this Sep 11, 2019
@mmorhun
Copy link
Contributor

mmorhun commented Sep 11, 2019

@metlos could you please elaborate a bit more on the problem, because I've checked the logo image from issue title and the path to it is relative:
image-path

@metlos
Copy link
Contributor Author

metlos commented Sep 11, 2019

@mmorhun, yep, it is now relative. Not sure what caused the change.

@mmorhun
Copy link
Contributor

mmorhun commented Sep 11, 2019

I've checked other resources (which I could found in the plugin) including css and js: all of them have relative path.
@metlos can we resolve this issue?

@mmorhun mmorhun closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmorhun mmorhun

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.2.0
Development

No branches or pull requests
4 participants
@metlos @slemeur @mmorhun @che-bot