Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve devfile:generate command #14460

Closed
11 tasks
benoitf opened this issue Sep 9, 2019 · 4 comments
Closed
11 tasks

Improve devfile:generate command #14460

benoitf opened this issue Sep 9, 2019 · 4 comments
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Sep 9, 2019

From chectl created by l0rd: che-incubator/chectl#100

  • Support config maps
  • Better input sanity check: verify that a plugin provided as a parameter has a valid format
  • Find a better way to generate src/api/devfile.ts (currently done via quicktype.io)
  • complete devfile/generate.test.ts
    • make nock work
    • parse yaml output and verifies, for each kind, the number of items and the fields that should exist and those that should not.
  • Add an e2e test:
    kubectl create namespace prod
    kubens prod
    kubectl apply -f https://raw.githubusercontent.com/sleshchenko/NodeJS-Sample-App/dockerCon/deploy_k8s.yaml
    chectl devfile:generate \
            --selector="app.kubernetes.io/name=employee-manager" \
            --language=typescript \
            --git-repo='https://github.com/sleshchenko/NodeJS-Sample-App.git'
    kubectl delete services --all -n prod
    kubectl delete deployment --all -n prod
  • Support specifying multiple selectors (e.g. --selector="name=springboot" --selector="name=mysql")
  • Support specifying multiple languages (e.g. --language=java --language=go)
  • Support specifying multiple plugins
  • Support --file as an alternative to --namespace as a source for k8s resources
@benoitf
Copy link
Contributor Author

benoitf commented Sep 9, 2019

@l0rd I think it makes sense to support generating a devfile from a file as well. For example, for this Demo project https://github.com/sleshchenko/NodeJS-Sample-App it would look like the following

chectl devfile:generate \
        --file=deploy_k8s.yaml
        --language=typescript \
        --git-repo='https://github.com/sleshchenko/NodeJS-Sample-App.git'

And then generated Devfile may reference this file instead of inlining content.
WDYT?

@benoitf
Copy link
Contributor Author

benoitf commented Sep 9, 2019

Good idea @sleshchenko I have updated the description

@benoitf benoitf added the area/chectl Issues related to chectl, the CLI of Che label Sep 9, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 9, 2019
@l0rd
Copy link
Contributor

l0rd commented Sep 9, 2019

@benoitf @sleshchenko looks like a good idea indeed

@ibuziuk ibuziuk added severity/P2 Has a minor but important impact to the usage or development of the system. kind/enhancement A feature request - must adhere to the feature request template. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 9, 2019
@che-bot
Copy link
Contributor

che-bot commented Mar 11, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2020
@che-bot che-bot closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants