Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After updating Monaco Editor some Keybindings has collision for Java LS #14520

Closed
4 of 23 tasks
musienko-maxim opened this issue Sep 12, 2019 · 6 comments
Closed
4 of 23 tasks
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@musienko-maxim
Copy link
Contributor

musienko-maxim commented Sep 12, 2019

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  • Create a workspace based on Java Maven stack. Open HelloWorld.java class
  • Set cursor in 6:18 position (on .out) and invoke Ctrl+F12 shortcut
    Expected result: The Go to the definition command should be invoked. The System class should be opened.
    Actual result: Looks like instead of Go to definition command is invoked Go to implementation command

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

go-defenition-key-map

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

This problem can be depended on the Keybinding map, which has some duplicated Keybindings. See on screenshot. Also i supposed that this problem can be reproduced for other language servers because the KeyMap has other duplications.

@musienko-maxim musienko-maxim added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 12, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 12, 2019
@tsmaeder
Copy link
Contributor

@musienko-maxim I think this issue should be opened against the theia repo.

@tsmaeder tsmaeder added severity/P2 Has a minor but important impact to the usage or development of the system. team/languages and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 12, 2019
@tsmaeder
Copy link
Contributor

P2 because there is an easy workaround.

@tsmaeder
Copy link
Contributor

This has nothing to do with Java: VS Code does not define any keybindings.

@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 12, 2019

I checked in theia master: go to def is f12, go to impl is <ctrl>f12

@tsmaeder tsmaeder added this to the Backlog - Languages milestone Sep 23, 2019
@tsmaeder
Copy link
Contributor

FWIW: I tried reproducing this but was not able to get che to work on minishift

@svor
Copy link
Contributor

svor commented Oct 18, 2019

Default keybinding was changed, so for now:

  • ctrl+f12 - Go to Implementation
  • ctrl+f11 - Go to Definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants