Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Che Theia build failed #14685

Closed
mmorhun opened this issue Sep 27, 2019 · 8 comments
Closed

Che Theia build failed #14685

mmorhun opened this issue Sep 27, 2019 · 8 comments
Assignees
@benoitf
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@mmorhun
Copy link
Contributor

mmorhun commented Sep 27, 2019

Is your task related to a problem? Please describe.

After some changes in Theia upstream, build of Che Theia is broken.
We need to make corresponding changes in Che Theia.
@mmorhun mmorhun added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 27, 2019
@mmorhun mmorhun self-assigned this Sep 27, 2019
@mmorhun
Copy link
Contributor Author

mmorhun commented Sep 27, 2019

We're temporary switching to 0.11.0 version of Che Theia (see eclipse-che/che-theia#451), so I think we can lower a bit issue severity.

@mmorhun mmorhun added severity/P1 Has a major impact to usage or development of the system. and removed severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Sep 27, 2019
@tolusha tolusha added the area/editor/theia Issues related to the che-theia IDE of Che label Sep 27, 2019
@tolusha
Copy link
Contributor

tolusha commented Sep 27, 2019

I personally don't want to postpone for uncertain amount of time, that's why I prefer blocker.

@benoitf
WDYT ?

@benoitf
Copy link
Contributor

benoitf commented Sep 27, 2019

@tolusha well I will propose another PR which will fix the code. But it unblocks all ppl now.

@tolusha tolusha changed the title Catch up with changes in Eclipse Theia upstream (26.09.2019) Che Theia build failed Sep 27, 2019
@benoitf
Copy link
Contributor

benoitf commented Sep 27, 2019

@tolusha I mean, I will work on it, it's not to push it back until 3 weeks

@mmorhun mmorhun assigned benoitf and unassigned mmorhun Sep 27, 2019
@benoitf benoitf added team/devex area/editor/theia Issues related to the che-theia IDE of Che and removed area/editor/theia Issues related to the che-theia IDE of Che team/ide2 labels Sep 27, 2019
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Sep 27, 2019 •
edited
Loading

Build failure log: https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/Che-Theia-master-check-E2E-Happy-path-tests-against-K8S/125/console

lerna ERR! $ yarn clean && yarn build
lerna ERR! $ rimraf lib
lerna ERR! $ concurrently -n "format,lint,compile" -c "red,green,blue" "yarn format" "yarn lint" "yarn compile" && yarn run compileWorker
lerna ERR! [format] $ tsfmt -r --useTsfmt ../../configs/tsfmt.json
lerna ERR! [compile] $ tsc
lerna ERR! [lint] $ tslint -c ../../configs/tslint.json --project tsconfig.json
lerna ERR! [format] yarn format exited with code 0
lerna ERR! [lint] yarn lint exited with code 0
lerna ERR! [compile] src/browser/plugin/che-plugin-frontend-service.ts(39,56): error TS2339: Property 'getDeployedMetadata' does not exist on type 'HostedPluginServer'.
lerna ERR! [compile] src/browser/plugin/che-plugin-frontend-service.ts(42,36): error TS2339: Property 'source' does not exist on type 'PluginMetadata'.
lerna ERR! [compile] src/browser/plugin/che-plugin-frontend-service.ts(43,31): error TS2339: Property 'source' does not exist on type 'PluginMetadata'.
lerna ERR! [compile] src/browser/plugin/che-plugin-frontend-service.ts(44,34): error TS2339: Property 'source' does not exist on type 'PluginMetadata'.
lerna ERR! [compile] src/browser/plugin/che-plugin-frontend-service.ts(46,38): error TS2339: Property 'source' does not exist on type 'PluginMetadata'.
lerna ERR! [compile] src/browser/plugin/che-plugin-frontend-service.ts(46,64): error TS2339: Property 'source' does not exist on type 'PluginMetadata'.
lerna ERR! [compile] src/browser/plugin/che-plugin-frontend-service.ts(46,90): error TS2339: Property 'source' does not exist on type 'PluginMetadata'.
lerna ERR! [compile] src/browser/plugin/che-plugin-frontend-service.ts(50,38): error TS2339: Property 'source' does not exist on type 'PluginMetadata'.
lerna ERR! [compile] error Command failed with exit code 2.

@benoitf
Copy link
Contributor

benoitf commented Sep 27, 2019

@dmytro-ndp it should be fixed, no ?
Happy path test was successful on eclipse-che/che-theia#451

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Sep 27, 2019 •
edited
Loading

let me check it again in master branch

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Sep 27, 2019 •
edited
Loading

Build of master has finished successfully https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/Che-Theia-master-check-E2E-Happy-path-tests-against-K8S/126/

@benoitf benoitf mentioned this issue Sep 30, 2019
Merged
@evidolob evidolob closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitf benoitf

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@benoitf @evidolob @dmytro-ndp @tolusha @mmorhun