Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable branding on the ConsoleLink elements created by the che operator #14809

Closed
davidfestal opened this issue Oct 8, 2019 · 3 comments
Closed

Enable branding on the ConsoleLink elements created by the che operator #14809

davidfestal opened this issue Oct 8, 2019 · 3 comments
Assignees
@ibuziuk
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.4.0

Comments

@davidfestal
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

Currently ConsoleLink object created by the Che operator has fixed upstream Che branding.

Describe the solution you'd like

it should be possible to override the name, display name and icon of the ConsoleLink object created by the operator.

Additional context

This is related to this issue comment: #14745 (comment)
@davidfestal davidfestal added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 8, 2019
@davidfestal
Copy link
Contributor Author

cc @nickboldt @l0rd

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 8, 2019
@l0rd l0rd added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 8, 2019
@l0rd
Copy link
Contributor

l0rd commented Oct 8, 2019

I am setting it as severity/P2 as it doesn't have a major impact on UX but I am ok to bring it to 7.3.0 if the fix is easy: how could we override name/display name/icon for CRW build only?

@l0rd l0rd added team/osio status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach labels Oct 8, 2019
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach labels Oct 16, 2019
@ibuziuk ibuziuk added this to the 7.4.0 milestone Oct 16, 2019
@ibuziuk ibuziuk self-assigned this Oct 16, 2019
@l0rd l0rd mentioned this issue Oct 22, 2019
Closed
30 tasks
@ibuziuk ibuziuk mentioned this issue Oct 22, 2019
Merged
@ibuziuk
Copy link
Member

ibuziuk commented Oct 25, 2019

PR eclipse-che/che-operator#101 merged, Closing

@ibuziuk ibuziuk closed this as completed Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibuziuk ibuziuk

Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.4.0
Development

No branches or pull requests
4 participants
@l0rd @davidfestal @ibuziuk @che-bot