Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia - variable in previewurl is not evaluated after clicking right-bottom notification popup #14820

Closed
5 tasks done
sparkoo opened this issue Oct 9, 2019 · 0 comments
Closed
5 tasks done
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@sparkoo
Copy link
Member

sparkoo commented Oct 9, 2019

Describe the bug

Having defined previewUrl in command. After running the command, right-bottom notification will pop-up. The URL that is shown in notification is properly evaluated. But clicking on "Preview" button opens un-evaluated URL.

The support for previewUrl in devfile is not merged yet. However, issue can be manually reproduced by editing tasks.json file. Follow steps to reproduce.

Simple devfile to test:

---
apiVersion: 1.0.0
metadata:
  generateName: dummy-go-server-with-one0endpoint
projects:
  -
    name: dummy-http-server
    source:
      type: git
      location: "https://github.com/sparkoo/dummy-http-server.git"
components:
  -
    type: dockerimage
    image: quay.io/eclipse/che-golang-1.10:nightly
    alias: go-cli
    mountSources: true
    memoryLimit: 256Mi
commands:
  -
    name: run 8080
    actions:
      -
        type: exec
        component: go-cli
        command: "go run main.go 8080 /hello"
        workdir: ${CHE_PROJECTS_ROOT}/dummy-http-server

Che version

  • nigihtly

Steps to reproduce

  1. start workspace with devfile above
  2. open .theia/tasks.json file
  3. add parameter to task "previewUrl": "${server.theia}"
  4. save .theia/tasks.json and run the command
  5. right-bottom notification with previewUrl should appear. URL to theia component is correct there
  6. click on "Preview" button in the right-bottom notification
  7. opened URL is http://${server.theia}, but it should be properly evaluated.

Expected behavior

URL should be evaluated

Runtime

  • minikube (include output of minikube version and kubectl version)

Screenshots

previewurl_notif
previewurl_notif2

Installation method

  • helm

Environment

  • my computer
    • Linux

Additional context

"Preview" button from bottom Previews panel works ok.

previewUrl support in devfile is currently in review.

@sparkoo sparkoo added the kind/bug Outline of a bug - must adhere to the bug report template. label Oct 9, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 9, 2019
@RomanNikitenko RomanNikitenko self-assigned this Oct 9, 2019
@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 9, 2019
@l0rd l0rd added this to the Backlog - IDE 1 milestone Oct 11, 2019
@vparfonov vparfonov modified the milestones: Backlog - IDE 1, 7.4.0 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants