Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a wsmaster property to specify workspaces default security context #15138

Closed
l0rd opened this issue Nov 6, 2019 · 3 comments
Closed

Add a wsmaster property to specify workspaces default security context #15138

l0rd opened this issue Nov 6, 2019 · 3 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@l0rd
Copy link
Contributor

l0rd commented Nov 6, 2019

Is your enhancement related to a problem?

Currently workspace containers are run as unprivileged arbitrary users (uid is a random number of multiple digits). That has some benefits from a security point of view and works well on secured Kubernetes clusters. But some users may come with containers that only work when run as root on an unsecured cluster. See #14330

Describe the solution you'd like

Add a wsmaster property that specify the default workspace pods SecurityContext runAsUser attribute (default)

c.f.
https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-the-security-context-for-a-container
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.16/#securitycontext-v1-core

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Nov 6, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 6, 2019
@tsmaeder tsmaeder added severity/P2 Has a minor but important impact to the usage or development of the system. team/platform kind/enhancement A feature request - must adhere to the feature request template. and removed kind/enhancement A feature request - must adhere to the feature request template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 7, 2019
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Nov 14, 2019
@l0rd
Copy link
Contributor Author

l0rd commented Nov 14, 2019

I have raised this issue as P1 because there are use cases where Che worksapces are not usable at all if we enforce hard security constraints as running pods as arbitrary users.

@skabashnyuk skabashnyuk added this to the Backlog - Platform milestone Nov 20, 2019
@kfox1111
Copy link

kfox1111 commented Jan 6, 2020

Not sure this is the right issue to file this under or not. Please let me know if it is a different issue. I'd like to specify user uid's in keycloak identity tokens, and then have che workspaces run under the user's uid. This would allow extra mounts like existing nfs home directories to be made safely available to che users when integrated with keycloak/ldap.

@che-bot
Copy link
Contributor

che-bot commented Jul 6, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2020
@l0rd l0rd removed the severity/P1 Has a major impact to usage or development of the system. label Jul 6, 2020
@che-bot che-bot closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants