Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable chectl to install Che through OLM when appropriate #15279

Closed
davidfestal opened this issue Nov 21, 2019 · 3 comments
Closed

Enable chectl to install Che through OLM when appropriate #15279

davidfestal opened this issue Nov 21, 2019 · 3 comments
Assignees
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@davidfestal
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

Currently, chectl allows installing, updating or deleting Che on an OpenShift 4.2 cluster. But it still uses the raw yaml method (deploy the operator, roles, service account etc ... through yaml files) instead of using the OLM (OperatorHub)-compatible method (by subscription to the OLM package channel.).

More than that, trying to update or delete, with chectl, a Che installation that was initially installed through OperatorHub, will not work propertly, and also lead to inconsistencies.

Describe the solution you'd like

In chectl, we should have an olm installer, and make it the default installer on Openshift 4.2 cluster.
Additionally, we should probably test whether an existing Che operator deployment was initially installed through OLM (easy to do through annotations) before trying to either update or delete it through alternate installers.
With the new olm installer, users would also be able to install Che in a given namespace without having admin rights since it's mainly subscribing to an operator OLM package already available in one of the available OLM catalogs.

Describe alternatives you've considered

For now it has been said that documentation should clearly state that, on OpenShift 4.2, OperatorHub and chectl installation methods should never be mixed.
However this doesn't fully remove the risk of getting errors due to this situation.

@davidfestal davidfestal added kind/enhancement A feature request - must adhere to the feature request template. area/chectl Issues related to chectl, the CLI of Che labels Nov 21, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 21, 2019
@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 22, 2019
@tolusha tolusha added this to the Backlog - Deploy milestone Dec 12, 2019
@tolusha tolusha mentioned this issue Jan 27, 2020
35 tasks
@tolusha tolusha mentioned this issue Feb 17, 2020
46 tasks
@tolusha tolusha mentioned this issue Mar 5, 2020
45 tasks
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Mar 25, 2020
@tolusha tolusha mentioned this issue Mar 27, 2020
43 tasks
@tolusha tolusha mentioned this issue Apr 16, 2020
50 tasks
@tolusha tolusha closed this as completed Apr 24, 2020
@tolusha tolusha modified the milestones: Backlog - Deploy, 7.13 Apr 24, 2020
@nickboldt
Copy link
Contributor

So this is a new install approach for OCP 4.2+?

Questions for downstreaming:

  • since crwctl is only recommended for OCP 3.11, we should either omit this option from crwctl, or include it but don't recommend it (since it would only be useful if a user is choosing to use crwctl instead of operatorhub on OCP 4 [not recommended], or the target OCP 3.11 has operatorhub installed in it manually).

  • what happens if the olm approach is used on OCP 3.11 w/ operator hub installed and the operator metadata includes digests?? I have the impression that OCP 3.11 doesn't support image digests so... would that break?

@davidfestal
Copy link
Contributor Author

@nickboldt

  • As soon as this new OLM installation method will come from upstream chectl into downstream crwctl, we would be able to make crwctl a usable / recommended / supported installation method for OpenShift 4 as well, as long as crwctl installs with the new OLM installation method by default on this platform.
  • I assume OLM method would not be allowed on Openshift 3.11 in crwctl, and in such a case crwctl would issue an error message. Am I right @tolusha ?

@AndrienkoAleksandr
Copy link
Contributor

I assume OLM method would not be allowed on Openshift 3.11 in crwctl, and in such a case crwctl would issue an error message.

Yes, it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants