Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vert.x default sample #15314

Closed
slemeur opened this issue Nov 26, 2019 · 3 comments
Closed

Update vert.x default sample #15314

slemeur opened this issue Nov 26, 2019 · 3 comments
Assignees
@svor @tsmaeder
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@slemeur
Copy link
Contributor

slemeur commented Nov 26, 2019

Is your task related to a problem? Please describe.

The sample project is based on an older version version of Vert.x that likely has several CVEs, but most importantly it is essentially a Spring application with Vert.x inside with many wrong usages: blocking operations because of Spring Data, raw HTTP dispatch rather than using a router, etc.

Describe the solution you'd like

Replace the default vert.x sample by: https://github.com/openshiftio-vertx-boosters/vertx-http-booster

Additional context

Raised by vert.x team.
@slemeur slemeur added kind/task Internal things, technical debt, and to-do tasks to be performed. team/languages labels Nov 26, 2019
@slemeur slemeur changed the title Replace vert.x default sample Update vert.x default sample Nov 26, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 26, 2019
@tsmaeder
Copy link
Contributor

According to @slemeur we have a better example in CRW. It uses this repo: https://github.com/openshiftio-vertx-boosters/vertx-http-booster
We can take over that example, but make sure we don't have any dependencies on Red Hat products.

@tsmaeder
Copy link
Contributor

The new sample should replace the Java-Web-Vertx sample, as far as I'm concerned.

@tsmaeder tsmaeder mentioned this issue Nov 26, 2019
Closed
26 tasks
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 26, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Nov 27, 2019

There is also https://github.com/openshift-vertx-examples/vertx-http-example.git which is used in the https://github.com/redhat-developer/devfile/tree/master/getting-started/vertx for "getting-started" devfiles. Please, consider updating this one also

@svor svor self-assigned this Dec 4, 2019
This was referenced Dec 10, 2019
Merged
Merged
@svor svor closed this as completed Dec 10, 2019
@dmytro-ndp dmytro-ndp mentioned this issue Dec 13, 2019
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svor svor

@tsmaeder tsmaeder

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@l0rd @svor @ibuziuk @slemeur @tsmaeder @che-bot