-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework che-theia branding to provide logo icon for plugin webview #15324
Comments
Related to #15283 |
yes |
do you have ETA of the size of the logo encoded in base64 ? |
~ 12K |
@l0rd could we assign it to Plugins team? |
This is a blocker for CodeReady Workspaces 2.1 and a regression over 2.0. Please escalate this so we can get it into 7.9.1, as this is a terrible OOTB visual experience. Alternatively, please provide a way to suppress the icon entirely as it's really not that meaningful or needed. BTW I thought 7.9.0 was supposed to be about hardening and UX fixes. How did this obvious UX problem fall through the cracks for 3 months? |
@nickboldt how exactly is this a blocker? I don't really want to hear people's own opinion and musings but we have an agreement that blocker means 'Causes system to crash and be non-recoverable or prevents Che developers from working on Che code'. If we all start barging in with our ideal 'blocker' definition it will get pretty crowded. And it didn't fall through any crack - it was just not prioritized. If you think it should have been you are most welcome to join us when we prioritize as we are good listeners. |
Is your task related to a problem? Please describe.
After change web-view eclipse-theia/theia#6465, webview doesn't have access to the resources outside plugin.
Describe the solution you'd like
We need to rework che-theia branding to provide logo icon for plugin web-view.
The text was updated successfully, but these errors were encountered: