Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Native Compilation Commands to Quarkus Devfile #15630

Closed
tsmaeder opened this issue Jan 8, 2020 · 4 comments
Closed

Add Native Compilation Commands to Quarkus Devfile #15630

tsmaeder opened this issue Jan 8, 2020 · 4 comments
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template.

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Jan 8, 2020

The current Quarkus devfile does not contain any commands to native-compile the example application. This is because on che.openshift.io, we only have 3Gb per workspace available.
This task consists of adding the necessary commands for native compilation to that devfile in a way that graciously fails if there is not enough memory available. In particular, we don't want the workspace or any containers to be OOM-killed by the platform.
Ideally, native compilation could be started, but would fail with a nice error message when it runs out of memory.

@tsmaeder tsmaeder added kind/enhancement A feature request - must adhere to the feature request template. team/languages area/languages Issues related to Language extensions or plugins integration. labels Jan 8, 2020
@tsmaeder tsmaeder mentioned this issue Jan 8, 2020
35 tasks
@amisevsk
Copy link
Contributor

amisevsk commented Jan 8, 2020

From my experience, it's hard to know whether a process or the whole container will be killed in an OOM situation.

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Jan 8, 2020

We don't need a 100% solution: if the behaviour is good 99% of the time, I'm fine with that.

@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2021
@ericwill ericwill removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2021
@ericwill
Copy link
Contributor

ericwill commented Feb 4, 2021

This has been implemented for awhile now.

@ericwill ericwill closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

4 participants