Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve che:theia production command to correct repack theia dependencies #15748

Closed
vzhukovs opened this issue Jan 20, 2020 · 2 comments
Closed

Improve che:theia production command to correct repack theia dependencies #15748

vzhukovs opened this issue Jan 20, 2020 · 2 comments
Assignees
@vzhukovs
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@vzhukovs
Copy link
Contributor

Is your task related to a problem? Please describe.

After latest build failure (related issue: #15695) there was provided temporary solution, that adds missing dependency to the theia generator assembly-package.mst#L73. As a temporary solution it works fine, but there is a need to review the che:theia production command (production.ts) to be able to repack correct dependencies in case if upstream project provide more than one dependency that have two versions.

Describe the solution you'd like

Filter dependencies and look for the one dependency with more than one version and took the latest one into che-theia image assembly.

Describe alternatives you've considered

Not yet discussed.

Additional context

None
@vzhukovs vzhukovs added kind/task Internal things, technical debt, and to-do tasks to be performed. team/editors area/editor/theia Issues related to the che-theia IDE of Che labels Jan 20, 2020
@vzhukovs vzhukovs self-assigned this Jan 20, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 20, 2020
@vzhukovs vzhukovs added the severity/P2 Has a minor but important impact to the usage or development of the system. label Jan 20, 2020
@ibuziuk ibuziuk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 20, 2020
@TheRealChssAddct
Copy link

Yarn as of version 1.21.1 no longer allows colons in symlink names. Therefore che:theia should no longer be the name of the command. It should probably be changed to che-theia.

(The problematic issue is yarn 1.21.1 will no longer validate the "bin" symlink with a colon in it (currently line is line 8 the bin https://github.com/eclipse/che-theia/blob/master/generator/package.json)

@vzhukovs vzhukovs mentioned this issue Jan 21, 2020
Closed
2 tasks
@azatsarynnyy azatsarynnyy mentioned this issue Mar 11, 2020
Closed
19 tasks
@che-bot
Copy link
Contributor

che-bot commented Jul 27, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2020
@che-bot che-bot closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vzhukovs vzhukovs

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ibuziuk @vzhukovs @che-bot @TheRealChssAddct