Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pinning non che-sample projects in devfile registry to specific commits #15898

Open
JPinkney opened this issue Jan 31, 2020 · 3 comments
Labels
area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@JPinkney
Copy link
Contributor

JPinkney commented Jan 31, 2020

Is your enhancement related to a problem? Please describe.

After working on #15852 I think it might be wise to start pinning the projects referenced in the devfiles in the devfile registry to specific commits. As it stands it looks like many (if not all?) projects in the devfile registry just use master branch. Of course when they are che-samples we can create a stable branch and reference that in the devfile. However, for other upstream samples that aren't worked on by members of this community we end up having to play a cat and mouse game where master branch changes something and we now have to go into the devfile registry and adjust a task, etc. Although this means we would without a doubt eventually be behind master, we gain the ability to ensure that our devfiles are stable and that if a user wants to start a workspace with a devfile from the registry all tooling and tasks will be working all the time.

Describe the solution you'd like

I'd like us to pin devfiles to specific commits so that we won't run into issues like #15852

Describe alternatives you've considered

None

Additional context

@JPinkney JPinkney added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 31, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 31, 2020
@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. area/devfile-registry and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 31, 2020
@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 3, 2020

+1.

@tsmaeder
Copy link
Contributor

I think for sample where release tags exist, that would be more customary. Otherwise commit hashes make sense.

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 21, 2020
@ericwill ericwill added this to the Backlog - Plugins milestone Aug 21, 2020
@ericwill ericwill added severity/P2 Has a minor but important impact to the usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. labels Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants