Error highlighting broken in several default stack

[Katka92]

Describe the bug

Error highlighting feature is not working in several default stacks in 7.8.0.
Affected stacks:

• NodeJS Express Web Application
• NodeJS MongoDB Web Application
• PHP Symfony
• PHP with MySQL
• PHP Laravel with MySQL
• Rust
  EDIT: added .net core stack
• .NET Core

Che version

• other: 7.8.0 on che.prod-preview.openshift.io

Steps to reproduce

1. Go to Workspaces -> Add Workspace
2. Select one of the stacks from the description of the issue
3. Open the file and write some erroneous text to it
4. Erroneous words are not highlighted

Expected behavior

Erroneous code should be highlighted by a red underline.

Runtime

• other: (please specify) che.prod-preview.openshift.io

Environment

• other: please specify che.prod-preview.openshift.io

[l0rd]

@Katka92 can you provide some logs (c.f. the doc to retrieve language servers logs)?

[tsmaeder]

@Katka92 are the plugins starting at all? Do you get content assist, for example? I know that the node support writes progress messages to the status bar when starting up.

[tsmaeder]

NodeJS Express works just fine on local crc. I suspect this is some limitation on prod-preview.

[Katka92]

Hi, thank you for your answers. In some devfiles just error highlighting was not working as expected, in other devfiles also other features. Now there is a new issue for 4 days with Java Maven stack that LS seems to not work at all. #16051

[Katka92]

On 7.9.0 Hosted che on prod-preview error highlighting is not working for a Rust devfile, but code suggestion and completion seems to be working correctly.

[Katka92]

The issue is still present for 7.12.0 tested on Hosted Che.

[ibuziuk]

@ericwill could you please take a look?

[ericwill]

Yes we've planned it for next sprint (184).

[ericwill]

I tried today on che.openshift.io and it turns out the PHP stacks (Symfony, MySQL, and Laravel) work fine. Rust and NodeJS are still broken.

[ericwill]

NodeJS with React is also broken.

[tsmaeder]

Checking:

✔️ NodeJS Express Web Application
❌ NodeJS MongoDB Web Application
✔️ PHP Symfony
✔️ PHP with MySQL
✔️ PHP Laravel with MySQL
✔️ Rust: there is no language plugin for Rust in the Che plugin registry: this works as designed.

[tsmaeder]

There seems to be an element of randomness to this: I have observed the node/mongodb workspace start the language server successfully, but most of the time, it fails.

[tsmaeder]

When the LS startup failed, I was this stack trace in the typescript container log:

PLUGIN_HOST(1): PluginManagerExtImpl/loadPlugin(/tmp/vscode-unpacked/che-incubator.typescript.latest.zkalzvuwgu.che-typescript-language-1.35.1.vsix/extension/out/extension)
Remote plugin in vscode-typescript5dp: promise rejection is not handled in two seconds: TypeError: vscode.workspace.onDidRenameFile is not a function
Remote plugin in vscode-typescript5dp: promise rejection stack trace: TypeError: vscode.workspace.onDidRenameFile is not a function
    at new UpdateImportsOnFileRenameHandler (/tmp/vscode-unpacked/che-incubator.typescript.latest.zkalzvuwgu.che-typescript-language-1.35.1.vsix/extension/out/features/updatePathsOnRename.js:42:41)
    at ConditionalRegistration.dependentRegistration_1.VersionDependentRegistration [as _doRegister] (/tmp/vscode-unpacked/che-incubator.typescript.latest.zkalzvuwgu.che-typescript-language-1.35.1.vsix/extension/out/features/updatePathsOnRename.js:181:128)
    at ConditionalRegistration.update (/tmp/vscode-unpacked/che-incubator.typescript.latest.zkalzvuwgu.che-typescript-language-1.35.1.vsix/extension/out/utils/dependentRegistration.js:23:42)
    at VersionDependentRegistration.update (/tmp/vscode-unpacked/che-incubator.typescript.latest.zkalzvuwgu.che-typescript-language-1.35.1.vsix/extension/out/utils/dependentRegistration.js:51:28)
    at new VersionDependentRegistration (/tmp/vscode-unpacked/che-incubator.typescript.latest.zkalzvuwgu.che-typescript-language-1.35.1.vsix/extension/out/utils/dependentRegistration.js:41:14)
    at Object.register (/tmp/vscode-unpacked/che-incubator.typescript.latest.zkalzvuwgu.che-typescript-language-1.35.1.vsix/extension/out/features/updatePathsOnRename.js:181:12)
    at TypeScriptServiceClientHost.Promise.resolve.then.then.module (/tmp/vscode-unpacked/che-incubator.typescript.latest.zkalzvuwgu.che-typescript-language-1.35.1.vsix/extension/out/typeScriptServiceClientHost.js:67:118)

[tsmaeder]

A new instance of the stack trace I reported has been spotted in the wild (from Mattermost):

hi all, before i post a bug report, i wanted to make sure i do it right and in the correct place.

The TS/JS tooling keeps crashing in the latest Che (7.16.2) for us. Stack from the container below: Is this a bug with the plugin, che, or what? and where should I report, or is it known?

Remote plugin in vscode-typescript4xq: promise rejection is not handled in two seconds: TypeError: vscode.workspace.onDidRenameFile is not a function
Remote plugin in vscode-typescript4xq: promise rejection stack trace: TypeError: vscode.workspace.onDidRenameFile is not a function
at new UpdateImportsOnFileRenameHandler (/tmp/vscode-unpacked/che-incubator.typescript.1.30.2.aaxqtsdhym.che-typescript-language.vsix/extension/out/features/updatePathsOnRename.js:31:49)
at ConditionalRegistration.dependentRegistration_1.VersionDependentRegistration [as _doRegister] (/tmp/vscode-unpacked/che-incubator.typescript.1.30.2.aaxqtsdhym.che-typescript-language.vsix/extension/out/features/updatePathsOnRename.js:241:103)
at ConditionalRegistration.update (/tmp/vscode-unpacked/che-incubator.typescript.1.30.2.aaxqtsdhym.che-typescript-language.vsix/extension/out/utils/dependentRegistration.js:23:42)
at VersionDependentRegistration.update (/tmp/vscode-unpacked/che-incubator.typescript.1.30.2.aaxqtsdhym.che-typescript-language.vsix/extension/out/utils/dependentRegistration.js:51:28)
at new VersionDependentRegistration (/tmp/vscode-unpacked/che-incubator.typescript.1.30.2.aaxqtsdhym.che-typescript-language.vsix/extension/out/utils/dependentRegistration.js:41:14)
at Object.register (/tmp/vscode-unpacked/che-incubator.typescript.1.30.2.aaxqtsdhym.che-typescript-language.vsix/extension/out/features/updatePathsOnRename.js:241:12)
at TypeScriptServiceClientHost.Promise.resolve.then.then.module (/tmp/vscode-unpacked/che-incubator.typescript.1.30.2.aaxqtsdhym.che-typescript-language.vsix/extension/out/typeScriptServiceClientHost.js:67:118)
at process._tickCallback (internal/process/next_tick.js:68:7)
Remote plugin in vscode-typescript4xq: promise rejection is not handled in two seconds: undefined>
Remote plugin in vscode-typescript4xq: promise rejection is not handled in two seconds: TypeError: Cannot read property 'stack' of undefined
Remote plugin in vscode-typescript4xq: promise rejection stack trace: TypeError: Cannot read property 'stack' of undefined
at /remote-endpoint/node_modules/@eclipse-che/theia-remote/lib/node/plugin-remote.js:36:25

19:29

ignore the 1.30.2 version, i switched from latest to test if 1.35 was the issue. It seemed like it was working, but eventually came back

[tsmaeder]

My suspicion is that initialization of the plugin host (aka overriding the module load) and plugin activation are happening at the same time. We could test this theory by putting a breakpoint in the plugin host to simulate delay.

[tsmaeder]

root ERROR [hosted-plugin: 20812] With stack trace: TypeError: s.workspace.onDidRenameFile is not a function

Note that this is looking for "onDidRenameFile", not "onDidRenameFiles". The "s" was added when the api graduated from vscode-proposed.ts to vscode.ts.
So in fact, we're looking at a version issue here: for newer version of Theia (about 4 months ago), we need a newer version of the typescript extension

[ericwill]

This has been fixed now that we've updated the typescript extension, no?

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

[l0rd]

@svor it's not clear from the description what's missing here

[svor]

@l0rd The typescript extension was updated and seems we don't have vscode.workspace.onDidRenameFile is not a function related problem any more.

I'm going to close the issue.