Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull requests extension upgrade from 0.8 to 0.14" _gitAPI.onDidChangeState is not a function" #16283

Closed
gattytto opened this issue Mar 7, 2020 · 8 comments
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach

Comments

@gattytto
Copy link

gattytto commented Mar 7, 2020

trying to upgrade the github pull requests ms-vscode extension in my plugin-registry I get the following from the extension:

"Activating extension GitHub Pull Requests failed: this._gitAPI.onDidChangeState is not a function."
image

referenced vsix is:
https://github.com/microsoft/vscode-pull-request-github/releases/download/0.14.0/vscode-pull-request-github-0.14.0.vsix

@gattytto gattytto added the kind/enhancement A feature request - must adhere to the feature request template. label Mar 7, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 7, 2020
@gattytto gattytto changed the title pull requests extension upgrade from 0.8 to 0.14"_gitAPI.onDidChangeState is not a function" pull requests extension upgrade from 0.8 to 0.14" _gitAPI.onDidChangeState is not a function" Mar 8, 2020
@ibuziuk
Copy link
Member

ibuziuk commented Mar 9, 2020

@gattytto could you please provide steps to reproduce? Basically, GH PR plugin is part of che-theia out of the box and not expected to be updated - https://github.com/eclipse/che-theia/tree/master/plugins/github-auth-plugin

@ibuziuk ibuziuk added kind/bug Outline of a bug - must adhere to the bug report template. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach area/plugins team/plugins severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. kind/enhancement A feature request - must adhere to the feature request template. labels Mar 9, 2020
@ibuziuk
Copy link
Member

ibuziuk commented Mar 9, 2020

cc: @ericwill

@ericwill
Copy link
Contributor

Yes please provide steps to reproduce the issue, specifically how you are "upgrading" the plugin.

@gattytto
Copy link
Author

gattytto commented Mar 10, 2020

@gattytto could you please provide steps to reproduce? Basically, GH PR plugin is part of che-theia out of the box and not expected to be updated - https://github.com/eclipse/che-theia/tree/master/plugins/github-auth-plugin

EDIT:
@ibuziuk re-reading your comment I see you mention that the plugin is not expected to be updated, but the referenced .vsix in the plugin meta.yaml is still being maintained and updated by its authors, and 0.13 version seems to include lots of bug fixes and improvements from the community.

The extension I am referring to is this one:
https://github.com/eclipse/che-plugin-registry/blob/master/v3/plugins/ms-vscode/vscode-github-pullrequest/0.8.0/meta.yaml

And this is the version I am trying to use:
https://github.com/gattytto/che-plugin-registry/blob/gopos/v3/plugins/ms-vscode/vscode-github-pullrequest/0.14.0/meta.yaml

@gattytto
Copy link
Author

Yes please provide steps to reproduce the issue, specifically how you are "upgrading" the plugin.

Above comment has the meta.yaml I added to my plugin registry

@gattytto
Copy link
Author

@ibuziuk I have edited my previous comment with a mention to you.

Can this be checked?

@ericwill
Copy link
Contributor

Duplicate of #16181

@ericwill ericwill marked this as a duplicate of #16181 Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Development

No branches or pull requests

4 participants