Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt changes in che-theia to respect changes in upstream theia #16393

Closed
vzhukovs opened this issue Mar 19, 2020 · 0 comments · Fixed by eclipse-che/che-theia#676
Closed

Adapt changes in che-theia to respect changes in upstream theia #16393

vzhukovs opened this issue Mar 19, 2020 · 0 comments · Fixed by eclipse-che/che-theia#676
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.

Comments

@vzhukovs
Copy link
Contributor

Is your task related to a problem? Please describe.

A new method was added:

undeployPlugin(pluginId: string): Promise<boolean>;

into PluginDeployerHandler. Implementation in che-theia should implement this method as well.

Additional context

Related upstream PR that brought this change: eclipse-theia/theia#6655
@vzhukovs vzhukovs added kind/task Internal things, technical debt, and to-do tasks to be performed. team/editors area/editor/theia Issues related to the che-theia IDE of Che labels Mar 19, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 19, 2020
@benoitf benoitf mentioned this issue Mar 19, 2020
Merged
@azatsarynnyy azatsarynnyy added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 19, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Mar 20, 2020
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deployment): Fix the plugin-remote init which is missing now a method benoitf/che-theia
3 participants
@azatsarynnyy @vzhukovs @che-bot