Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

che-theia init should work with commit hashes #17940

Open
1 of 3 tasks
tsmaeder opened this issue Sep 23, 2020 · 5 comments
Open
1 of 3 tasks

che-theia init should work with commit hashes #17940

tsmaeder opened this issue Sep 23, 2020 · 5 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P1 Has a major impact to usage or development of the system.

Comments

@tsmaeder
Copy link
Contributor

Describe the bug

When using che-theia I can check out out a particular commit hash, only branches. When we can't compile against current Theia master, we usually fix the build against that last commit (by hash) that che-theia still compiles against. This means that when we're in that state, our self-hosting process does not work with what we're currently shipping.

Che version

  • latest
  • nightly
  • other: please specify
@tsmaeder tsmaeder added kind/bug Outline of a bug - must adhere to the bug report template. area/dev-experience labels Sep 23, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 23, 2020
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 23, 2020
@azatsarynnyy
Copy link
Member

I see there are several options available:

./build.sh --build-args:${GITHUB_TOKEN},THEIA_COMMIT_SHA=1e09b816511769eb206494c1bac1a595e95795f9 --tag:next --git-ref:refs\\/heads\\/master --dockerfile:Dockerfile.alpine --skip-tests --branch:master

@tsmaeder
Copy link
Contributor Author

Or we just remove the -b when checking out stuff. I dont' think it would make a difference. Do you see one?

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Sep 24, 2020

before che-theia init, checkout Theia to a commit, that Che Theia is currently aligned with

@azatsarynnyy you're right, I'm being stupid here. Still: the fact that we're forced to using branches still is an unnecessary limitation that should be removed.

@azatsarynnyy
Copy link
Member

Or we just remove the -b when checking out stuff. I dont' think it would make a difference. Do you see one?

You're right @tsmaeder. That would be a really useful improvement.

@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. and removed kind/bug Outline of a bug - must adhere to the bug report template. labels Sep 24, 2020
@azatsarynnyy azatsarynnyy changed the title che-theia init does not work for commit hashes che-theia init should work with commit hashes Sep 24, 2020
@che-bot
Copy link
Contributor

che-bot commented Apr 6, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 6, 2021
@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 6, 2021
@l0rd l0rd self-assigned this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants