-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[che-theia] - open http preview in separate browser tab #18002
Comments
I'm not sure if we still support HTTP, but anyway it's not recommended as Che Theia WebView Plugin API works in secure contexts only, eclipse-theia/theia#6465 (comment). |
I see the following ways how Preview URL UX can be improved for single-host mode ⬇️ The Preview URL feature is configurable in Che Theia through user preferences: A user can choose in which mode an application's preview URL should be opened, by default (embedded/detached). There's the detailed description of all the possible modes: But this preference is respected by Task Plugin only. So that it works for the user applications that were run with Tasks only. There are two areas where it can be improved for single-host mode:
|
I'm moving the issue to |
ATM, there's a way to work it around by opening a preview URL in a separate browser's tab manually. |
Is this issue relevant? |
Even when I installed @sparkoo could you check the issue again? |
I'm closing it as non relevant. Feel free to open it if the problem is still present. |
Is your enhancement related to a problem? Please describe.
This issue #17840 will introduce option to expose user applications on subdomains in single-host mode. As we typically don't have certificate for such subdomains, so we're exposing those ports on HTTP only. As a result of that, che-theia can't show the preview, because HTTP content can't be loaded from HTTPS page.
Bonus task/question (is this for separate issue?):
In case of endpoint with attribute
protocol: 'https'
, it's exposed on HTTPS, but without valid certificate (we don't have one for subdomains in single-host). In that case, the "Potential security issue" browser page is shown. However, you can't "accept the risk" from the preview directly (I guess some browser security feature). You have to again open the URL in separate tab, then you can click the "accept the risk" button, and only then you can load the page in che-theia preview again. Can we do anything here to improve the user experience?Describe the solution you'd like
Che-theia should open HTTP URLs in new browser tab, instead of in-editor preview. In theory, when che-theia is on HTTP as well, it will work, but I guess we don't support that anymore.
Describe alternatives you've considered
n/a
Additional context
#17840
The text was updated successfully, but these errors were encountered: