Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce workspaces restart time #18672

Closed
2 tasks
Tracked by #14879
l0rd opened this issue Dec 19, 2020 · 5 comments
Closed
2 tasks
Tracked by #14879

Reduce workspaces restart time #18672

l0rd opened this issue Dec 19, 2020 · 5 comments
Labels
area/dashboard area/getting-started Issues related to the getting started samples https://www.eclipse.org/che/getting-started/cloud/ engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@l0rd
Copy link
Contributor

l0rd commented Dec 19, 2020 •
edited
Loading

Is your enhancement related to a problem? Please describe.

We are re-processing a Devfile at workspace restart. Even if the meta.yaml, sidecars, vsx have not changed.

Describe the solution you'd like

When a stopped workspace is restarted, we should retrieve again the included plugins definitions from the registry. We should just reuse the same spec used to start the workspace in the first place.

Getting started examples to start faster, should use the same mechanism. The spec of a getting started should not change until a new version of Che is released.

  • At restart, we should avoid to re-evaluate what has already been evaluated. If possible we should scale up the workspace Deployment.
  • Getting started examples should be pre-processed and use the restart mechanism even when a user starts it for the first time. If it make sense Che should pre-create all the getting started Deployments scaled to zero in a user namespace.

Additional context

This work should be included in the context of che workspaces that use the DevWorkspace operator, so that's not for v1 devfiles/plugins.
@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Dec 19, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 19, 2020
@l0rd l0rd added area/getting-started Issues related to the getting started samples https://www.eclipse.org/che/getting-started/cloud/ and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 20, 2020
@l0rd l0rd mentioned this issue Dec 20, 2020
Closed
@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Sep 6, 2021

/remove-lifecycle stale

@l0rd l0rd removed this from the DevWorkspace Integration - STEP3 milestone Sep 6, 2021
@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2021
@l0rd l0rd mentioned this issue Sep 28, 2021
Open
10 tasks
@l0rd l0rd added the roadmap/3-months Epics that are planned to complete in the short term (within 3 months) label Sep 29, 2021
@l0rd l0rd removed this from the DevWorkspace Integration - STEP3 milestone Sep 29, 2021
@l0rd l0rd added area/dashboard and removed kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. roadmap/3-months Epics that are planned to complete in the short term (within 3 months) labels Sep 29, 2021
@sleshchenko
Copy link
Member

The goal and scope for that enhancement is not clear for me.
I would say we can just close it, since on restart we don't reevaluate workspace config. And rebuilding stuff for getting started has a separate issue on devfile registry side I believe.

@che-bot
Copy link
Contributor

che-bot commented Apr 19, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2022
@l0rd
Copy link
Contributor Author

l0rd commented Apr 21, 2022

Closing as currently restarting is just about scaling up the replicas of the workspace deployment.

@l0rd l0rd closed this as completed Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dashboard area/getting-started Issues related to the getting started samples https://www.eclipse.org/che/getting-started/cloud/ engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@l0rd @sleshchenko @che-bot