Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to include an upstream Theia patch into Che-Theia release #19141

Closed
azatsarynnyy opened this issue Feb 24, 2021 · 1 comment · Fixed by eclipse-che/che-theia#1032
Closed

Document how to include an upstream Theia patch into Che-Theia release #19141

azatsarynnyy opened this issue Feb 24, 2021 · 1 comment · Fixed by eclipse-che/che-theia#1032
Assignees
@azatsarynnyy
Labels
area/doc Issues related to documentation area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone
7.28

Comments

@azatsarynnyy
Copy link
Member

Is your task related to a problem? Please describe.

During the last several months, there were a couple of times when it was needed to include an upstream Theia commit into CRW. It wasn't clear how to do it.

Describe the solution you'd like

Describe the possible options in Che-Theia's 'release.md' doc.
Option 1 is to use patches folder.
Option 2 is to use a fork of upstream Theia with the required commit cherry-picked. Possible this one https://github.com/redhat-developer/eclipse-theia can be used for such purpose.

Describe alternatives you've considered

Additional context
@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. area/editor/theia Issues related to the che-theia IDE of Che area/doc Issues related to documentation labels Feb 24, 2021
@azatsarynnyy azatsarynnyy added this to the 7.28 milestone Feb 24, 2021
@azatsarynnyy azatsarynnyy self-assigned this Feb 24, 2021
@azatsarynnyy azatsarynnyy changed the title Document how to inlcude an upstream Theia patch into Che-Theia release Document how to include an upstream Theia patch into Che-Theia release Feb 25, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Feb 25, 2021
Closed
11 tasks
@yhontyk
Copy link

yhontyk commented Mar 4, 2021

Docs Jira https://issues.redhat.com/browse/RHDEVDOCS-2741

@azatsarynnyy azatsarynnyy added status/in-progress This issue has been taken by an engineer and is under active development. sprint/current labels Mar 5, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Mar 16, 2021
Merged
9 tasks
@azatsarynnyy azatsarynnyy removed status/in-progress This issue has been taken by an engineer and is under active development. sprint/current labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/doc Issues related to documentation area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.28
Development

Successfully merging a pull request may close this issue.

Add a doc on how to include an upstream Theia patch into the Che-Theia release eclipse-che/che-theia
2 participants
@azatsarynnyy @yhontyk