Factory acceptance fails if there is no k8s namespace yet

[sleshchenko]

Is your task related to a problem? Please describe.

The PR eclipse-che/che-dashboard#183 integrates dashboard with Che Server Bitbucket OAuth flow implemented recently. But there is one drawback: oauth flow can't be finished is namespace does not exists and Dashboard can do nothing with it.

Che Server should try to precreate namespace when it does not exist on /api/kubernetes/namespaces method or on try to store bitbucket secret.

I'm open to discuss alternative if any.

[sleshchenko]

Dashboard workaround introduced in eclipse-che/che-dashboard#183 is broken, probably due changes on Che Server side #19518

It's how now the dashboard notifies users about namespace absence:

[cccs-eric]

I also ran into this issue while testing my GitHub integration with OAuth. Once my PR gets merged, we might see more and more occurrences of this problem since a lot of people are using GitHub. So this doesn't only apply to BitBucket, but also to GitHub eventually.

[mshaposhnik]

Honestly, i don't like idea that factory/resolve must create namespace. But twice much as that, i don't like the idea that factory/resolve must do a decision what exacly to create (namings etc).

Since dashb already doing the request to figure out list of user-s namespaces (and theirs existence),
my proposal is to send desired namespace name as the parameter of factory/resolve (which can take an unlimited number of parameters). In that case we can just do the usual routine using KubernetesNamespaceFactory with minimal modifications.

That will also help if user have multiple NS, so we will create token secrets exactly where is is specified by dashb and avoid mess.

@skabashnyuk @sleshchenko WDYT ?

[skabashnyuk]

Since dashb already doing the request to figure out list of user-s namespaces (and theirs existence),
my proposal is to send desired namespace name as the parameter of factory/resolve (which can take an unlimited number of parameters).

Dashboard does not know it. In that case, we need to provide a service that will tell what the namespace names should be.

That will also help if user have multiple NS

Users can have one and only one NS.

[mshaposhnik]

Service is already present and dashboard making requests to it. Link

[skabashnyuk]

@mshaposhnik I think it's better to rethink/refact che-server internals and create k8s namespace when it's needed.

[skabashnyuk]

should be covered by

• REST Service on the Che server-side that will initiate k8s namespace provisioning #20165
• [Dashboard] Ensure k8s namespace exists before workspace related operation #20167

[skabashnyuk]

Fixed #20165 and #20167