Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of CheCluster Custom Resource server devfileRegistryUrl and status devfileRegistryURL is confusing and error prone #19632

Closed
1 of 23 tasks
sunix opened this issue Apr 20, 2021 · 2 comments
Closed
1 of 23 tasks

Naming of CheCluster Custom Resource server devfileRegistryUrl and status devfileRegistryURL is confusing and error prone #19632

sunix opened this issue Apr 20, 2021 · 2 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@sunix
Copy link
Contributor

sunix commented Apr 20, 2021

Describe the bug

Looks like #19627 wasn't a bug. devfileRegistryURL instead of devfileRegistryUrl. However this is errorprone. Same for the pluginRegistryUrl: I had that issue 3 weeks ago not knowing what was wrong ... but probably the same problem

image

And broker not able to download plugins from the registry.
We cannot keep the "almost" the same names for these. Either they are the same, or we should use completely different names to avoid errors.

Che version

  • latest 7.29.0
  • nightly
  • other: please specify

Steps to reproduce

See #19627

Expected behavior

Maybe status.devfileRegistryURL should be renamed status.devfileRegistryUrl. (and status.pluginRegistryURL renamed status.pluginRegistryUrl) that would avoid error from the user.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • Dev Sandbox (workspaces.openshift.com)
  • other: please specify

Eclipse Che Logs

Additional context
@sunix sunix added the kind/bug Outline of a bug - must adhere to the bug report template. label Apr 20, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 20, 2021
@tolusha tolusha added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator and removed kind/bug Outline of a bug - must adhere to the bug report template. labels Apr 21, 2021
@ibuziuk ibuziuk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 26, 2021
@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2021
@tolusha
Copy link
Contributor

tolusha commented Nov 11, 2021

Close in favor of #20758

@tolusha tolusha closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sunix @ibuziuk @tolusha @che-bot