Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A project should be removed from devfile at using 'Remove Folder from Workspace' action #19730

Closed
1 of 3 tasks
RomanNikitenko opened this issue Apr 30, 2021 · 5 comments
Closed
1 of 3 tasks

A project should be removed from devfile at using 'Remove Folder from Workspace' action #19730

RomanNikitenko opened this issue Apr 30, 2021 · 5 comments
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Apr 30, 2021 •
edited
Loading

Describe the bug

We should remove a project from devfile when a user applies Remove Folder from Workspace action.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Start a workspace with a project
  2. Select the project in Projects Tree
  3. Apply Remove Folder from Workspace action using context menu.
  4. You can see that the project was removed from the Projects Tree view.
  5. Go to dashboard - the project is still in the devfile
  6. Try to refresh a page with IDE - the project will be restored in the Projects Tree view and workspace config file.

Expected behavior

A project should be removed from devfile.
I'm not sure if we should remove it from file system as well.

Runtime

dogfooding instance
@RomanNikitenko RomanNikitenko added kind/bug Outline of a bug - must adhere to the bug report template. area/plugins labels Apr 30, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 30, 2021
@RomanNikitenko RomanNikitenko mentioned this issue Apr 30, 2021
Closed
9 tasks
@azatsarynnyy
Copy link
Member

I'm not sure if we should remove it from file system as well.

It shouldn't touch a physical folder on the file system. It's just about the logical project structure and a Devfile.

@azatsarynnyy azatsarynnyy added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 30, 2021
@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2021
@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@azatsarynnyy
Copy link
Member

not a priority for the nearest future, but still relevant

@azatsarynnyy
Copy link
Member

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2021
@che-bot
Copy link
Contributor

che-bot commented May 3, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2022
@che-bot che-bot closed this as completed May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@azatsarynnyy @RomanNikitenko @che-bot